Broken symlink break sync about b2_command_line_tool

[jcalonso]

Yeah a warn would be great, and avoid stopping the syncing. 👍

Btw, the release from last week was amazing, it fixed my previous problems with encoding and the 'progress bar' is great! Good job guys!

[ppolewicz]

My pleasure!

[bwbeach]

What should sync do with symlinks?

Right now it's following the symlink. Which seems reasonable to me. What should it do with a broken symlink? Would a nice error message solve the problem?

[simongreen-net]

I'd prefer a --no-sync-symlink option (or something similar), but a warn option is good enough.

I use encfs before sending data offsite, so some symlinks don't exist.

[Telofy]

Permission denied errors have similar effects, i.e., also break off the sync. Something like this would be really cool:

diff --git a/b2/sync/folder.py b/b2/sync/folder.py
index 52af481..cb25e34 100644
--- a/b2/sync/folder.py
+++ b/b2/sync/folder.py
@@ -122,7 +122,7 @@ class LocalFolder(AbstractFolder):
             full_path = os.path.join(dir_path, name)
             relative_path = full_path[prefix_len:]
             # Skip broken symlinks or other inaccessible files
-            if not os.path.exists(full_path):
+            if not os.path.exists(full_path) or not os.access(full_path, os.R_OK):
                 if reporter is not None:
                     reporter.local_access_error(full_path)
             else:

[ppolewicz]

Reporter should be extended to handle permission errors. Thanks for the suggestion.

[Telofy]

Wow, thank you!