GithubHelp home page GithubHelp logo

Comments (10)

lgandecki avatar lgandecki commented on July 20, 2024 1

As I thought:

putting this:

  "cypress-cucumber-preprocessor": {
    "step_definitions": "test/cypress/support/step_definitions"
  }

in your package.json fixes the problem.

I'm thinking whether I should try to make it work for the mistakenly used "fileServerFolder": "test/cypress", as well, or just make a note in the documentation that this is no longer supported (it was deprecated a few versions back)

from cypress-cucumber-preprocessor.

lgandecki avatar lgandecki commented on July 20, 2024

Any chance of a simple reproduction? Also - could you go back a version or two and see if that helps?

from cypress-cucumber-preprocessor.

ChrisBAshton avatar ChrisBAshton commented on July 20, 2024

Just re-tried it in a few versions:

  • 1.2.2 broken, see error in this issue description
  • 1.2.0 broken, see error in this issue description
  • 1.1.0 works (but 1 of our tests fails for some reason!)
  • 1.0.0 works fully

So breaking change was introduced in 1.2.0.

from cypress-cucumber-preprocessor.

ChrisBAshton avatar ChrisBAshton commented on July 20, 2024

I'd take a wild guess and assume it's because path.relative got removed :)

from cypress-cucumber-preprocessor.

lgandecki avatar lgandecki commented on July 20, 2024

I mean, we don't resolve the paths manually anymore, so the whole operation from that line was removed.

For now I'd recommend: don't use fileServerFolder , as it was mistakenly used for our plugin purpose. Go with the cosmicconfig and step_definitions property as explained here: https://github.com/TheBrainFamily/cypress-cucumber-preprocessor#configuration

It would be great to have a reproduction (just try to have the same structure and config and strip everything specific to your project). Unless it will be hard to me to verify the problem.

from cypress-cucumber-preprocessor.

ChrisBAshton avatar ChrisBAshton commented on July 20, 2024

Ok!

Here's a test repo: https://github.com/ChrisBAshton/cypress-cucumber-debug

The master version passes tests, but the broken branch fails them: ChrisBAshton/cypress-cucumber-debug#1

from cypress-cucumber-preprocessor.

lgandecki avatar lgandecki commented on July 20, 2024

Cool! I will take a stab at this tonight.

from cypress-cucumber-preprocessor.

lgandecki avatar lgandecki commented on July 20, 2024

@ChrisBAshton It would be great if you could verify this fix and I'd love to hear your thoughts about removing the ability to use fileServerFolder for good, instead of fixing it :)

from cypress-cucumber-preprocessor.

ChrisBAshton avatar ChrisBAshton commented on July 20, 2024

Hi @lgandecki I can confirm that fixes it 🎉 but it does feel wrong to pollute the package.json with Cypress-specific properties 🤔 can't this be handled in the cypress.json?

Oh, and happy to remove fileServerFolder from the config.

from cypress-cucumber-preprocessor.

lgandecki avatar lgandecki commented on July 20, 2024

cypress.json is for cypress configuration, and you are not configuring cypress here, really. If you don't want to pollute package.json you have all the options that https://github.com/davidtheclark/cosmiconfig gives you

from cypress-cucumber-preprocessor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.