badisi / ngx-safe-subscribe

⛑️ Easy way to automatically unsubscribe from RxJS observables in Angular components

@badisi/ngx-safe-subscribe

⛑️ Automatically unsubscribe from RxJS observables in Angular components.

---

⚡ Angular <= 13 version available here

⚡ RxJS 5.x version available here

---

Installation

npm install @badisi/ngx-safe-subscribe --save

yarn add @badisi/ngx-safe-subscribe

Usage

SafeSubscribe is an augmentation method of Observable.

Calling safeSubscribe instead of subscribe will automatically unsubscribe your observable at component destroy.

Example with Angular components

import { Component, OnInit } from '@angular/core';
import { SafeSubscribe } from '@badisi/ngx-safe-subscribe';
import { interval } from 'rxjs';

@SafeSubscribe()
@Component({
   selector: 'app-component'
})
export class AppComponent implements OnInit {
   ngOnInit() {
      interval(1000).safeSubscribe(this, () => {
         console.log('This log will stop on component destroy.')
      });
   }
}

Example with simple class objects

import { SafeSubscribe } from '@badisi/ngx-safe-subscribe';
import { interval } from 'rxjs';

@SafeSubscribe('destroy')
export class MyObject {
   constructor() {
      interval(1000).safeSubscribe(this, () => {
         console.log('This log will stop on object destroy.')
      });
   }
   destroy() {}
}

Api

@SafeSubscribe(destructorName)

Arguments

• destructorName: string (default: "ngOnDestroy") - The name of the method that will be called when the object is supposed to be destroyed.

---

Observable.safeSubscribe(target, ...arguments): Subscription

Arguments

• target: any - A reference to the object that is holding the observable.
• observerOrNext?: Observer|Function - Either an observer with methods to be called, or the first of three possible handlers, which is the handler for each value emitted from the subscribed Observable.
• error?: Function - A handler for a terminal event resulting from an error. If no error handler is provided, the error will be thrown asynchronously as unhandled.
• complete?: Function - A handler for a terminal event resulting from successful completion.

Return

• A Subscription reference to the registered handler.

Purpose

To quote a great article from Netanel Basal :

When you subscribe to an observable or event in JavaScript, you usually need to unsubscribe at a certain point to release memory in the system. Otherwise, you will have a memory leak.

When subscribing to an observable in an Angular component, you almost always arrange to unsubscribe when the component is destroyed.

But it can quickly become a mess to deal with all those subscriptions and make sure they were properly released.

The idea behind SafeSubscribe is to abstract all the unsubscribe boilerplate and make it easier to use.

Rule of thumb

There are a few exceptional observables where you don't need to unsubscribe :

• Async pipe
• @HostListener
• HTTP requests
• Finite observables (such as Observable.timer)

However, as stated in the official Angular documentation :

Feel free to unsubscribe anyway. It is harmless and never a bad practice !

Contributing

> Want to Help ?

Want to file a bug, contribute some code or improve documentation ? Excellent!

But please read up first on the guidelines for contributing, and learn about submission process, coding rules and more.

> Code of Conduct

Please read and follow the Code of Conduct and help me keep this project open and inclusive.

ngx-safe-subscribe's Issues

I can't install your package by NPM... Idk why!

npm ERR! code E404
npm ERR! 404 Not Found: @badisi/ngx-safe-subscribe

Not working in production

Package is not bundled while building an Angular app for production

Version:
1.0.2 & 2.0.5

How to reproduce:
ng serve --prod

Results:
[error in console]: TypeError: Object(...)(...).safeSubscribe is not a function

Warning with EventEmitter

Hello Badisi,

Great code, thanks for sharing!

I am having an issue when using a setter for a Component's property.

_myElement: myElement;

@Output()
myElementChange = new EventEmitter<myyElement>();

@Input()
get myElement() {
	return this._myElement;
}

set myElement(newVal: myElement) {    
	if (this._myElement === newVal) { return; }
	this._myElement = newVal;
	this.cd.markForCheck();
	this.myElementChange.emit(this._myElement);
}

When calling this.myElementChange.emit(this._myElement);, the console shows the "should implement OnDestory..." warning.

Any thoughts on how to handle safeSubscribe in this situation?