Comments (5)
y-young
commented on August 16, 2024
你的意思是移到website包还是把逻辑去掉？感觉这个还算可以接受，倒是Topic那块可以考虑移出去，如果不用react-router-dom的话每次用Link都得router.push一下太麻烦了
from frontend.
FoundTheWOUT
commented on August 16, 2024
为什么要 push，直接写 to 就好了。
你的意思是移到website包还是把逻辑去掉？
把逻辑去掉，逻辑移到 website 做
from frontend.
y-young
commented on August 16, 2024
把逻辑去掉，逻辑移到 website 做
是external link的逻辑还是直接不用RouterLink？我觉得这块不是什么大问题
from frontend.
FoundTheWOUT
commented on August 16, 2024
当然是 RouterLink，有问题是因为现在 website 使用的自定义的 Link，不是 react-router-dom 提供的 Link
from frontend.
y-young
commented on August 16, 2024
现在没有自定义 Link 了，这个应该就不成问题了吧
from frontend.
Related Issues (20)
- test: 考虑引入 e2e 测试 HOT 4
- feat(wiki): 上传封面 HOT 19
- Bug: Button 嵌套 Link 时有效点击区域有限 HOT 8
- UX: 维基编辑页面提交后没有用户反馈
- Layout 布局
- design: Form 样式 HOT 4
- 统一测试写法 HOT 1
- design：添加更多toast样式 HOT 6
- docs: 在贡献指南注明开发服务器中的样例条目
- Bug: 应动态设置页面标题 HOT 6
- 没有 `to` 的情况下登陆成功后页面不会转跳 HOT 5
- use loading state HOT 4
- 要不要用一些类似 https://jotai.org/ 的全局状态管理工具？不然 Context 越加越多
- 移动端换行
- 短信收发
- Bug: 子评论的布局
- 内容区宽度调整 HOT 2
- 实现删除主题操作
- [bug report] 登录密码提示错误 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from frontend.