Question about the concurrency of Directory update about dash

[shiniaas]

Maybe it doesn't matter? Since thread 1 will go to retry.

[baotonglu]

Hi,

Sorry for the late reply. I don't think it has concurrency bugs but I agree it is hard to understand. Thus now I merge the counter with the directory lock as one RWLock, which simplifies the concurrency logic. Could you take a look?

Best,
Baotong

[shiniaas]

Thanks for your reply.
What I want to know is whether Directory_Update and Lock_Directory can run concurrently which may happen in such a situation described at the beginning. (#5 (comment)).
It seems in current implementation this situation won't happen.

[baotonglu]

In previous implementation, your proposed situation could happen but does not influence the correctness since thread 1 will retry. In current implementation, this situation won't happen.

[shiniaas]

Thanks!