Disabling image optimizations? about jekyll-now

[barryclark]

I took a look @benjholla. Love the look of questionablecode.org, by the way!

Your image looks good: https://questionablecode.org/assets/audit_resources/com.ext.ui/3.0/interesting_interactions.png and you've inserted it correctly. There's virtually no way that Jekyll could be causing a problem here, as what's being served is a static site, so if your image is fine, it must be something with the JS zoom box. It looks like the JS zoom box is zooming on the small version of the image, and not repainting the image upon zoom.

Closing as this isn't Jekyll Now (or Jekyll) related. Hopefully that helps you narrow things down, afraid I don't have time to debug the JS.

[benjholla]

Thanks for the help ruling out Jekyll. I knew it was a long shot, but maybe there was something I didn't know. Actually I pretty confident I tracked the bug down finally. Haven't fixed it yet, but turns out there is something that conflicts with my javascript/css of my zoom box and the jekyll-now output css and it just happens to manifest as a partially working zoom box.

[benjholla]

I found it!

In style.scss there was:

img {
max-width: 100%;
}

From what I can tell this is only used for the avatar image. So for my site I just moved max-width: 100%; (https://github.com/barryclark/jekyll-now/blob/master/style.scss#L109) to the line after site-avatar img attributes (https://github.com/barryclark/jekyll-now/blob/master/style.scss#L179).

That actually kind of make sense now...Thanks again for taking a look. I appreciate your project. Also I noticed for some reason I lost the "forked from" link. I made sure to re-fork to give proper attribution 👍

[barryclark]

Thanks @benjholla, I'm glad that you found the problem.

img { max-width: 100%; } sets all images to be fluid within their container, which is typically what you want in a blog post, and helpful at different responsive breakpoints. It'd make sense that was messing with the plugin. Good luck with the site! :)