GithubHelp home page GithubHelp logo

Comments (8)

barrykn avatar barrykn commented on June 25, 2024

Memo to self: RESIST THE TEMPTATION TO SLAM A FIX FOR THIS INTO PRODUCTION. THIS NEEDS TESTING FIRST.

from android-cm7-bkndh1.

barrykn avatar barrykn commented on June 25, 2024

Quoting from barrykn/android_frameworks_base-cm72-bkndh1@0e201a5:

"My gut feeling is that 1500ms won't be enough, but I think I'll give sanity a chance first."

Heh. I sure didn't expect it to take almost a year for my gut instinct to be validated, however.

from android-cm7-bkndh1.

barrykn avatar barrykn commented on June 25, 2024

Oops, I wasn't expecting "should fix" to automatically close this issue -- I still need to fix it for CM10.1.

from android-cm7-bkndh1.

barrykn avatar barrykn commented on June 25, 2024

I've coded a fix for CM10.1 but I have some more issues to file (and code fixes for) before I test.

from android-cm7-bkndh1.

barrykn avatar barrykn commented on June 25, 2024

I've tested the fix for both CM7.2 and CM10.1, but I'll leave this issue open until I get the CM10.1 code posted to GitHub.

from android-cm7-bkndh1.

barrykn avatar barrykn commented on June 25, 2024

By the way, 14.5 seconds is working fine in production on CM7.2. So far.

from android-cm7-bkndh1.

barrykn avatar barrykn commented on June 25, 2024

For the record: By the time this change became necessary, my user was much closer to the end of her life than I [had] realized [at the time]. [Edited 20130813 -- attempted to clarify this comment.]

from android-cm7-bkndh1.

barrykn avatar barrykn commented on June 25, 2024

In retrospect, perhaps 5 seconds would have been sufficient. However, I couldn't have been absolutely sure, and I didn't want to take any chances.

However, I do want to note that down in case I (or anyone) need(s) to revisit this issue at any point.

from android-cm7-bkndh1.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.