Comments (8)
Memo to self: RESIST THE TEMPTATION TO SLAM A FIX FOR THIS INTO PRODUCTION. THIS NEEDS TESTING FIRST.
from android-cm7-bkndh1.
Quoting from barrykn/android_frameworks_base-cm72-bkndh1@0e201a5:
"My gut feeling is that 1500ms won't be enough, but I think I'll give sanity a chance first."
Heh. I sure didn't expect it to take almost a year for my gut instinct to be validated, however.
from android-cm7-bkndh1.
Oops, I wasn't expecting "should fix" to automatically close this issue -- I still need to fix it for CM10.1.
from android-cm7-bkndh1.
I've coded a fix for CM10.1 but I have some more issues to file (and code fixes for) before I test.
from android-cm7-bkndh1.
I've tested the fix for both CM7.2 and CM10.1, but I'll leave this issue open until I get the CM10.1 code posted to GitHub.
from android-cm7-bkndh1.
By the way, 14.5 seconds is working fine in production on CM7.2. So far.
from android-cm7-bkndh1.
For the record: By the time this change became necessary, my user was much closer to the end of her life than I [had] realized [at the time]. [Edited 20130813 -- attempted to clarify this comment.]
from android-cm7-bkndh1.
In retrospect, perhaps 5 seconds would have been sufficient. However, I couldn't have been absolutely sure, and I didn't want to take any chances.
However, I do want to note that down in case I (or anyone) need(s) to revisit this issue at any point.
from android-cm7-bkndh1.
Related Issues (13)
- Look everything over and figure out what I changed HOT 6
- Make defy boot automatically when it starts charging, like an iPhone HOT 1
- Remove 2waysup volume button hack
- Add support for Motorola Defy+ HOT 4
- Possibly add support for the Samsung Dart HOT 5
- Consider adding Quarx2k's new battd (at least for jordan) HOT 2
- Port my changes forward to Jelly Bean (CM10.1/Android 4.2) HOT 16
- Simplify call detail HOT 2
- Remove search buttons from all-contacts & call log
- fix CYAN-1602 for CM7.2 HOT 3
- Create a CHANGES file (Gingerbread)
- Create a CHANGES file (Jelly Bean)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from android-cm7-bkndh1.