Comments (8)
I don't like "" for "everything". None as a default value makes more sense.
Why raising an IntegrityError and overwriting the save method? It's already checked in the form.
from django-attachments.
I'll switch to None :)
As for overriding the save() method, there we have model validation, while in the form it only checks on the upload form. You can still attach other types from shell etc.
from django-attachments.
What should '' mean? If a user chooses to set:
ATTACHMENTS_ALLOWED_TYPES = ''
from django-attachments.
I dont see the need for validation on model level, if the admin does that from the shell, he should take care of it.
I'm fine with the form validation but I have some minor nits how it's currently done. I try to add this feature asap and leave that file open.
from django-attachments.
Fine, let's ditch the validation at the model level :)
from django-attachments.
I've published a branch[1] on launchpad which includes this update and a way to limit the total size of attachments per model here:
https://code.launchpad.net/~panosl/+junk/django-attachments
from django-attachments.
I didn't heard of a need for this in teh past, I'm going to close this. Thank you.
from django-attachments.
@bartTC I have a similar albeit different requirement. Is there currently a way to restrict which file types can be attached (globally or per model/form)? If not can you point me to a way to work around it?
from django-attachments.
Related Issues (20)
- How do I allow Anon users to add attachments?
- Instead of renaming attachments with same name, store them in subdirectories
- Attaching items to new instance
- Attaching files to a new entry HOT 1
- No module named 'django.contrib.staticfilesattachments' HOT 2
- Add model method that gives path to file with MEDIA_DIR prepended. HOT 2
- ValueError: invalid literal for int() with base 10: '24890e2e-3515-4303-ab8c-344737c1d63f' HOT 9
- How to incorporate into a object create form? HOT 1
- Does `python_2_unicode_compatible` break in a current version? HOT 2
- Question: using django-attachments with a dynamic text editor HOT 5
- v1.6 missing tar.gz on PyPI while previous versions ship it HOT 1
- Set request.user as creator in django-admin. HOT 3
- How do I make a new release ? HOT 6
- v1.7 db_index for object_id field fails on MariaDB HOT 1
- Broken link in README.rst
- FileField 'max_length' is set to default in the attachment. Can we increase this possibly?
- Can Model's FileField import automated while create objects?
- NoReverseMatch exception using with models that have columns of type uuid4 as primary key HOT 3
- Error on click to attachment download link HOT 1
- Pipfile vs tox.ini HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from django-attachments.