Comments (4)
Hi,
I just wanted to open the same issue. The lib looks really promising. I don't want to be forced to use a specific CSS-in-JS solution. I only want to reuse the logic of a select component. @based-ghost what do you think about this approach JedWatson/react-select#2706 (comment)
from react-functional-select.
@StarpTech - Ahhh, yes in retrospect I wish I would have taken the time to build this out in a more modular way upfront, so that consumers of the package could opt-out of styled-components (thereby, avoiding the need to eat that dependency). At the time I started deving this lib the React Hooks API
was fairly new, so writing the lib without the use of classic class components + providing the opt-out of CSS-in-JS functionality proved to be a little more than I was able to handle at the time.
Your comment reminded me to take another look at this though, since this is something I did want to investigate and there is probably a way to smoothly integrate this with the current lib. I wrote this lib in a way that would make it flexible for additions/changes like this - so, hopefully that proves to be the case with this functionality.
I'll keep you posted and also take a look into how react-select
handled this - as that package was a source of inspiration for many other features I incorporated.
from react-functional-select.
No, not at the moment at least. However, looking at the roadmap for v5 of styled-components made it the best choice of all of the CSS-in-JS libraries in my opinion (in terms of performance and bundle-size). Version 5 is currently in a release-candidate state but it is stable and I have been using it in various projects with no issues, so, if you are worried about how it contributes to your bundle size v5 has a 31% smaller bundle-size than v4:
npm i [email protected]
from react-functional-select.
Hi @based-ghost thanks for the feedback and keep up the good work.
from react-functional-select.
Related Issues (20)
- Suggestion: open dropdown at top when don't have enough place HOT 4
- To styling with different states HOT 5
- Controlled input value HOT 7
- I can't customize control container as much as I like HOT 3
- Some bugs I spotted... HOT 1
- Order of multi-select tags not preserved. HOT 2
- Accessibility issue/question HOT 4
- How to set selected option from outside? HOT 2
- Mount the dropdown menu outside the parent div HOT 3
- Is sortable multi-select supported? HOT 2
- Separate render prop for control vs menu
- Support for VariableSizeList
- Feedback after first test
- Missing types
- Cannot add styles for Single Value HOT 1
- SSR error with nextjs HOT 1
- Not rendered options
- No tag / release for version 5.0.0 HOT 1
- initialValue prop not working? HOT 3
- Got an error: 'Cannot read properties of undefined (reading 'withConfig')' during the testing with RTL HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-functional-select.