GithubHelp home page GithubHelp logo

Comments (5)

based-ghost avatar based-ghost commented on May 23, 2024

@OGoodness - After looking for potential causes of the errors I believe the culprit was the use of the <p> tag to wrap another element (this is known to cause issues in SSR). I replaced the two offending instances with <div> tags, so hopefully that resolves it. If it does not let me know and I can dig deeper.

Thanks!

from react-seo-friendly-spa-template.

OGoodness avatar OGoodness commented on May 23, 2024

Doesn't seem to resolve this for me.
Here's the process I'm using to host/build the UI if it helps:

  1. npm run build
  2. docker-compose up

Dockerfile

FROM nginx
COPY ./build/ /usr/share/nginx/html/

docker-compose.yml

version: "2"
services:
  web:
    build: . # Path to dockerfile
    ports:
      - "2233:80"
      - "2234:443"

Using your repo directly, so everything else should be the same

from react-seo-friendly-spa-template.

OGoodness avatar OGoodness commented on May 23, 2024

@based-ghost I'm not very familiar with this form of SSR, do these errors even matter from a performance or SEO standpoint?

from react-seo-friendly-spa-template.

based-ghost avatar based-ghost commented on May 23, 2024

@OGoodness - sorry, forgot to push an update for this issue (after which I'm not recieving any errors). I looked through react-snap source code/documentation and came across configurations to handle "third-party requests", or in our case, anayltics requests. The following entry needed to be added to package.json:

"reactSnap": {
  "skipThirdPartyRequests": true
}

This does directly impact the static HTML that is generated during the prerender step and, therefore, has all the potential to impact SEO. During the build process you may notice the following error logged (per route): Failed to load resource: net::ERR_FAILED. This is a non-issue as it represents the analytics request being intercepted.

Also, I think my first comment/fix can be ignored as that issue should be unique to SSR - not SSG.

from react-seo-friendly-spa-template.

OGoodness avatar OGoodness commented on May 23, 2024

Thank you! Sorry for the debug request, not as familiar with the different intricacies of UI rendering and it's effect on SEO or response time. I'll test this out when I can!

from react-seo-friendly-spa-template.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.