GithubHelp home page GithubHelp logo

Comments (6)

mpellegrini avatar mpellegrini commented on September 26, 2024

Wondering if the mentioned PR mentioned above would get merged?

from duplicate-finder-maven-plugin.

hgschmie avatar hgschmie commented on September 26, 2024

Hi, thanks for the ping. This is related to multi-release jars and requires a more comprehensive change to the plugin. I am planning to do this when I find time.

As a workaround, you can add this pattern in your pom as well.

from duplicate-finder-maven-plugin.

mpellegrini avatar mpellegrini commented on September 26, 2024

Thanks for the quick reply. I have added the ignore pattern to my pom for the time being.

Thanks for your work on producing a very useful plugin!!

from duplicate-finder-maven-plugin.

stevenschlansker avatar stevenschlansker commented on September 26, 2024

This problem is continuing to spread -- latest releases of very popular jars like assertj and byte-buddy now conflict with each other.

from duplicate-finder-maven-plugin.

hgschmie avatar hgschmie commented on September 26, 2024

I need to find time to work out how to deal with multi-release jars. PRs very welcome

from duplicate-finder-maven-plugin.

hgschmie avatar hgschmie commented on September 26, 2024

This is fixed in the next version. I am planning that the next version will be the last one that runs on JDK8 and the one after will be JDK9+ exclusive.

In that version, I am planning to do more work with multi-release jars; currently there is a corner case where a duplicate class is not detected:

Base jar contains no conflicts
  |
  +-- META-INF/versions/9/A.class    is a conflict with an existing class on the class path

the current plugin would not detect this conflict when running under JDK9. To be able to manage these type of conflicts, the code must analyze the Multi-Release flag from the manifest and then build a map on which classes are actually visible on the class path. Very doable but I see no point in doing this for the JDK 8 version.

from duplicate-finder-maven-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.