compaction spins on corrupt sst about eleveldb

[jonmeredith]

See also https://help.basho.com/tickets/1224

[matthewvon]

This is a temporary hack. This change causes the code to skip over a corrupted block. Previous logic would report the error to upper layers which would:

a. cause compaction to begin looping infinitely, or
b. cause repair to throw away an entire file of key/values instead of just the single corrupted one.

Bad news is that the layer of the fix does NOT have access to logging. This skipping is going to happen silently for a while. Not happy about that at all.

branch is platform23-skip-corruption

[jonmeredith]

Is this resolved by basho/leveldb#6 ?

[matthewvon]

This is a dead branch. The fix here has been superseded by mv-badblock-recovery in leveldb. Not shire what to do about this ... close it?

[jonmeredith]

Yes, just click 'comment and close' on github.

On Sun, Jun 3, 2012 at 9:52 PM, matthewvon <
[email protected]

wrote:

This is a dead branch. The fix here has been superseded by
mv-badblock-recovery in leveldb. Not shire what to do about this ... close
it?

---

Reply to this email directly or view it on GitHub:
#23 (comment)