GithubHelp home page GithubHelp logo

Comments (3)

NiLuJe avatar NiLuJe commented on June 4, 2024

Likely the flash. Can't really be helped on devices without proper Eclipse waveform modes (i.e,, Mk 8+). (I mean, if you want to keep the flash, that is :D. And you generally do.).

(IIRC, there's a Plato fork that attempts to modulate the frontlight level during nightmode refreshes, but that's extremely difficult to achieve in a consistent manner across a wide range of devices in my experience (outside of doing in in-kernel), so, YMMV).

from plato.

randomnoise avatar randomnoise commented on June 4, 2024

@NiLuJe, thanks for the information. Flash contributes to the situation and I don't want to deal with the kernel space on e-readers yet, I am new to this stuff 😄

The issue that I am having is related to the Plato though, it isn't about hardware or kernel. I opened the issue as a feature request but I think that it is a Plato bug.

I've skimmed through the code and I found this:

fn render(&self, fb: &mut dyn Framebuffer, _rect: Rectangle, fonts: &mut Fonts) {
let scheme = if self.halt ^ fb.inverted() {
TEXT_INVERTED_HARD
} else {
TEXT_NORMAL
};

It looks like the code handles what I was asking (using black background in sleep screen if color is inverted) but there are if fb.inverted() { code blocks following that. So, I think the code undoes the change it did in the first place.

I think it should just be

let scheme = TEXT_NORMAL;

or something similar.

from plato.

randomnoise avatar randomnoise commented on June 4, 2024

To make the my suggestion clear visually, in stock Plato 0.9.40, Home screen with inverted color and Sleeping screen with white background:

03-inverted-main-menu 04-inverted-sleeping

from plato.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.