GithubHelp home page GithubHelp logo

Comments (3)

bassmanitram avatar bassmanitram commented on September 26, 2024

The problem is (still) in the "min_items/max_items" cross-property validator - it corrupts the model as items are moved. This is likely because it is called on every change to the model, not just at the end of a set of changes.

from actions-for-nautilus.

bassmanitram avatar bassmanitram commented on September 26, 2024

I was trying to be too "fine-grained" with the consistency checks! EVERY part of the model is presented to the validator, so rather than address the min and max properties individually, we can just wait until the "Basic" block of a command action is presented as a whole and then check it - this avoids having to introspect the editors and reduces the check to on (albeit long) if statement.

This tackles the persistent problem but it leaves one problem that I can't quite get a handle on yet - when you move a command action that is in error (particularly, has the min/max inconsistency) "past" a menu item, the command action in error becomes a menu action - with even more errors! I'll tackle this problem in a separate issue.

from actions-for-nautilus.

bassmanitram avatar bassmanitram commented on September 26, 2024

OK, I take that back - another tweak to the condition for the check - making it more targetted - fixes the "moving action-in-error" issue too. I think we're good to go!

from actions-for-nautilus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.