Comments (3)
The problem is (still) in the "min_items/max_items" cross-property validator - it corrupts the model as items are moved. This is likely because it is called on every change to the model, not just at the end of a set of changes.
from actions-for-nautilus.
I was trying to be too "fine-grained" with the consistency checks! EVERY part of the model is presented to the validator, so rather than address the min and max properties individually, we can just wait until the "Basic" block of a command action is presented as a whole and then check it - this avoids having to introspect the editors and reduces the check to on (albeit long) if statement.
This tackles the persistent problem but it leaves one problem that I can't quite get a handle on yet - when you move a command action that is in error (particularly, has the min/max inconsistency) "past" a menu item, the command action in error becomes a menu action - with even more errors! I'll tackle this problem in a separate issue.
from actions-for-nautilus.
OK, I take that back - another tweak to the condition for the check - making it more targetted - fixes the "moving action-in-error" issue too. I think we're good to go!
from actions-for-nautilus.
Related Issues (20)
- Not working on Ubuntu 22.10 HOT 13
- ShowIfTrue feature would be nice! HOT 2
- Open a terminal as root in a specific folder HOT 3
- Nautilus Desktop HOT 1
- JQuery gets 404 in configurator HOT 4
- how can I see the debug output? HOT 3
- Actions that I created find themselves in double in « Nautilus »... HOT 6
- not an issue, for the Wiki HOT 2
- actions-for-nautilus doesn't handle specials character in filenames... HOT 12
- Auto TAG debian package with github commit...
- Action that requires user input HOT 5
- hide/disable entries in the web interface HOT 1
- Static port for web interface HOT 2
- Blank page when starting AFN HOT 9
- Highlight Save button in Orange for unsaved settings HOT 1
- Using pipe to another command to display progress bar... HOT 1
- Does not work with commands that use placeholders
- Handling simple and double quotes in filenames... HOT 1
- Add commands to top of context menu HOT 2
- [Security] Port remains open after webpage is closed HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from actions-for-nautilus.