GithubHelp home page GithubHelp logo

Comments (5)

fmeum avatar fmeum commented on August 27, 2024 1

I can reproduce it now, I was on an older commit when I first tried this.

from bazel-gazelle.

mpatou avatar mpatou commented on August 27, 2024

Note it's not just custom gazelle_binaryusing what is proposed by rules_python is also not working:

gazelle(
    name = "gazelle",
    data = GAZELLE_PYTHON_RUNTIME_DEPS,
    gazelle = "@rules_python//gazelle:gazelle_python_binary",
)

from bazel-gazelle.

fmeum avatar fmeum commented on August 27, 2024

If I check out rules_python and update the Gazelle version in examples/build_file_generation to v0.32.0, running bazel run //:gazelle in that directory succeeds. Could you check whether you are using the latest version of rules_python?

from bazel-gazelle.

mpatou avatar mpatou commented on August 27, 2024

I am. I have a synthetic repro that is a few files only I can upload it somewhere if you want to have a look.

from bazel-gazelle.

fmeum avatar fmeum commented on August 27, 2024

I can reproduce this with Gazelle up to v0.32.0, but not with v0.33.0. I think that it was fixed by e3deb49.

@aignas It looks like some :gazelle target in rules_python's examples were broken without causing CI failures. In bazel-gazelle, we run the targets explicitly in CI and check that there is no diff for the examples. That could provide additional test coverage.

from bazel-gazelle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.