Comments (3)
At the moment go_grpc_library
is just a wrapper for go_proto_library
with a specific compiler. I'd like to make Gazelle migrate existing instances of go_grpc_library
to go_proto_library
(see #8).
I think it's reasonable to have an option that explicitly sets the compiler
attribute on generated go_proto_library
rules though.
FYI, you can use buildozer to make bulk changes like this to rules. Should be easier than forking and modifying Gazelle.
from bazel-gazelle.
After a little bit more thought it probably makes more sense to allow caller to override the implementation of go_proto_library or go_rpc_library instead
from bazel-gazelle.
It would be nice if this could also be defined for the go_repository
, so e.g. I could specify
go_repository(
name = ".....",
commit = "....",
importpath = "...",
build_file_proto_compiler = "@io_bazel_rules_go//proto:gogofaster_grpc",
)
But I suppose that is more specific to the rules_go repo. So opened an issue there for it.
from bazel-gazelle.
Related Issues (20)
- gazelle generates and recreates grpc targets that rules_go complains about HOT 6
- Missing documentation and best practices for bzlmod HOT 9
- Support Golang Workspaces in Gazelle HOT 6
- gazelle 0.35.0 panics HOT 4
- #gazelle:proto file” directive isn’t usable unless option go_package is explicitly set in each proto_library HOT 18
- Error in fail: failed to fetch com_github_gorilla_mux: go: missing Git command.
- Gazelle requires WORKSPACE when using update-repos in a bzlmod only repo HOT 4
- Gazelle fails with `BUILD file not found in directory` for Go module HOT 2
- Gazelle:resolve support bzlmod repo canonical name HOT 1
- Enhancement request: Add global go_binary gc_linkopts capability
- gazelle looking for WORKSPACE in bzlmod enabled project HOT 3
- Gazelle reports "could not merge expression" when using select statements in hdrs or srcs HOT 1
- Proto generation is not yet disabled in go.mods provided by go_deps in bzlmod
- Gazaelle not recognising math/rand/v2 as stdlib HOT 1
- Include @protobuf as option for resolving well-known types
- Failure when building //cmd/gazelle:gazelle_lib with bazel HOT 2
- Poor failure message when go.sum contains a merge-conflict HOT 2
- Adding non-strings (eg: a function) to a target's deps
- FR: Gazelle should import direct dependencies directly without requiring buildozer HOT 4
- concurrent map read and map write HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bazel-gazelle.