GithubHelp home page GithubHelp logo

Comments (3)

jayconrod avatar jayconrod commented on July 4, 2024 1

At the moment go_grpc_library is just a wrapper for go_proto_library with a specific compiler. I'd like to make Gazelle migrate existing instances of go_grpc_library to go_proto_library (see #8).

I think it's reasonable to have an option that explicitly sets the compiler attribute on generated go_proto_library rules though.

FYI, you can use buildozer to make bulk changes like this to rules. Should be easier than forking and modifying Gazelle.

from bazel-gazelle.

johnskopis avatar johnskopis commented on July 4, 2024

After a little bit more thought it probably makes more sense to allow caller to override the implementation of go_proto_library or go_rpc_library instead

from bazel-gazelle.

Globegitter avatar Globegitter commented on July 4, 2024

It would be nice if this could also be defined for the go_repository, so e.g. I could specify

go_repository(
        name = ".....",
        commit = "....",
        importpath = "...",
        build_file_proto_compiler = "@io_bazel_rules_go//proto:gogofaster_grpc",
    )

But I suppose that is more specific to the rules_go repo. So opened an issue there for it.

from bazel-gazelle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.