GithubHelp home page GithubHelp logo

Comments (5)

gregmagolan avatar gregmagolan commented on June 10, 2024

#106 adds yarn_install which can accept a yarn.lock file.

from rules_nodejs.

alexeagle avatar alexeagle commented on June 10, 2024

@gregmagolan does that mean if you keep using npm, you'll have floating deps? Meaning we won't fix this?

from rules_nodejs.

gregmagolan avatar gregmagolan commented on June 10, 2024

@gregmagolan does that mean if you keep using npm, you'll have floating deps? Meaning we won't fix this?

I added the ability a package_lock_json attribute to the npm_install rule in #106. This should make it deterministic but I'm not too familiar with npm locks files or the non-hermetic behavior observed with npm.

from rules_nodejs.

alexeagle avatar alexeagle commented on June 10, 2024

okay cool, we should fix the determinism too but that's not this issue.

We should update our rules that use npm_install to include package-lock.json...

from rules_nodejs.

gregmagolan avatar gregmagolan commented on June 10, 2024

package_lock_json attribute added in #106 which resolves this

from rules_nodejs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.