Comments (11)
This theme can be fixed as:
(custom-set-faces
'(mode-line ((t (:underline nil))))
'(mode-line-inactive ((t (:underline nil))))))
from solarized-emacs.
It's supposed to look like that to make it easier to see separation of buffers, there is a customization to allow it to look different.
;; make the modeline high contrast
(setq solarized-high-contrast-mode-line t)
from solarized-emacs.
It is there to make an inactive buffer separator:
As you can see with both header-line and mode-lines and active and inactive windows the underlining makes things alot clearer, ideally I would want to be able to use an real outline but thats is not currently possible. You can use a box but then all sided must have the same color and that looks worse (to me).
from solarized-emacs.
(setq solarized-high-contrast-mode-line t)
is not the look that I'am looking for, I find the modeline too bright.
Now I understand why it's here. But why did the underline is of the buffer separator is brighter that the top one? And why the underline is this close to the character?
I find the default theme separator implementation nicer:
- The two lines are the same color,
- The underline is well behind the characters (ie: it doesn't cross the p of "Lisp").
Anyway thanks for your quick response!
from solarized-emacs.
The reason for a slightly more accented line is because it divides the windows, it's only used between windows. It is used for both horizontal and vertical lines.
The underline is drawn according to the base line of the type face used:
from solarized-emacs.
Making these things work while tanking the limitations of the solarized palette and emacs facedefs in mind is not super easy thing to do.
from solarized-emacs.
@thomasf I understand that it can be tedious and appreciate your work on this beautiful theme.
I solved it by adding this to my init.el:
(setq x-use-underline-position-properties nil)
(setq underline-minimum-offset 4)
from solarized-emacs.
Thanks!
I did not know about those things, great if it works for you.. I guess that it will make regular underlines from flycheck/flyspell etc. look a bit strange and possibly also hide underscore completely under the underlines.
I like how it looks having the underlines at the bottom, I will try that as well for some time.
from solarized-emacs.
btw, this seems to do the same thing:
(setq x-underline-at-descent-line t)
from solarized-emacs.
Sorry to chime in like that but I just did a git bisect to figure out why my modeline looked crossed and came along this issue once I knew the commit. Next time I should check the issue list beforehand I guess. :)
Just wanted to say: I am also in the camp that the line w/ a brighter color and its general position is distracting and not really ideal imho. Especially if you use something like powerline or alike, it looks broken.
I did not know about the x-underline-at-descent-line either... I guess that one is a keeper and makes for better readability in my mind. It almost entirely masks the line issue which is nice as well. ;)
from solarized-emacs.
I'll add it to the reame, for now.
from solarized-emacs.
Related Issues (20)
- is MELPA the only way to install solarized-emacs? HOT 1
- After `emacs -nw`, themes gets messed up on GUI Emacs HOT 2
- Bad visibility of swiper matches
- Seems like load-theme's NO-ENABLE parameter is ignored HOT 2
- Line number style changes depending on leading whitespace HOT 1
- remove Underline
- Next release / addition to NonGNU ELPA HOT 3
- Missing faces for tab-bar mode
- Link to bottomline/baseline image in README broken HOT 1
- Compilation of package fails in Emacs 28 due to change in define-function-obsolete-alias HOT 5
- Color not shown correctly on ssh HOT 3
- Dependency on dash not present in emacs package
- Solarized 1.3.0 package not compatible with dash 2.19.1? HOT 2
- Error: Wrong number of arguments: (3 . 4), 2 HOT 3
- There is no distance between the background color of fringe and default. HOT 1
- modeline bottom border wrong position HOT 2
- Markdown header scaling
- Invalid face box: :line-width, 4, :color, "grey90", :style, nil HOT 3
- Compilation warnings & other small issues HOT 2
- How do I add a theme for a new package?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from solarized-emacs.