How to further customize? about zenburn-emacs

[dabrahams]

There are two issues here. First, problems with :inherit aside, I'd like to know what approach you recommend for customizing a theme like zenburn.

Second, are you sure there's a problem with :inherit? It doesn't look like that bug report is very well-understood still. Nobody provided a simple test case and I can't reproduce the behavior. For example, loading the following with emacs -Q -lthis-file seems to work perfectly.

;; define a couple of faces to be used in the theme
(defface face1
    '((t :background "pink"))
    "first test face")
(defface face2
    '((t :background "yellow"))
    "second test face")

;; simulate (load 'theme1)
(deftheme theme1
  "1st test theme")
(custom-theme-set-faces
 'theme1
 '(face2 ((t (:slant italic :inherit (face1)))))
 '(face3 ((t (:background "yellow"))))
 '(face4 ((t (:inherit (face3))))))
(provide-theme 'theme1)
;; done loading theme1

;; define some more faces used in the theme
(defface face3
    '((t :background "pink"))
    "3rd test face")
(defface face4
    '((t :slant italic))
    "4th test face")

;; inspect the faces
(setq inhibit-startup-screen t)
(customize-apropos-faces "^face[0-9]")

It seems to me that if there were an issue here it should be reproducible with (at least a simple variation on) this code.

[bbatsov]

Unfortunately there is something wrong with faces inheritance in customization themes (there are a couple of issues in the Emacs tracker on the subject) - that's why I've mostly removed inheritance from the new version of the theme. Check out this discussion http://debbugs.gnu.org/cgi/bugreport.cgi?bug=8454