color-theme-select broken about zenburn-emacs

[bbatsov]

As far as I know there is no color-theme package shipped with Emacs 23.3. If you're using the color-theme package that is in zenburn's repo - it's very stripped down and doesn't have all the other themes. I'll investigate the issue further.

[bo0ts]

Entirely my mistake.
I use color-theme 6.6.0-4 as packaged in the ArchLinux repositories. Which seems to be the latest stable version. There isn't anything that seems related to this issue in the color-theme bug tracker though.

[bo0ts]

This seems related: http://www.emacswiki.org/emacs/ColorTheme#toc2

[bbatsov]

I've fixed the erc-default problem, hopefully everything will be working ok for you now.

[bo0ts]

Unfortunately not:

Messages:
Loading /usr/share/emacs/site-lisp/themes/color-theme-library.el (source)...done
face-attribute: Invalid face: font-lock-warning

[bbatsov]

Hmm, that's odd. It certainly works for me and the face definition looks totally correct.

[bo0ts]

Ok, as I got into the habbit of switching themes that bug kept disturbing me more and more.

Here is a patch that fixes it, although I have to admit, that I have no idea what I'm actually doing here.
This works for color-theme 6.6.0 and Emacs 23.3.1.

diff --git a/color-theme-zenburn.el b/color-theme-zenburn.el
index 18b79b9..ca544ea 100644
--- a/color-theme-zenburn.el
+++ b/color-theme-zenburn.el
@@ -185,13 +185,13 @@
;; eshell
(eshell-prompt ((t (:inherit zenburn-strong-1-face))))
(eshell-ls-archive ((t (:foreground ,zenburn-red-1 :weight bold))))

• (eshell-ls-backup ((t (:inherit font-lock-comment))))
  

• (eshell-ls-clutter ((t (:inherit font-lock-comment))))
  

• (eshell-ls-backup ((t (:inherit font-lock-comment-face))))
  

• (eshell-ls-clutter ((t (:inherit font-lock-comment-face))))
  

  (eshell-ls-directory ((t (:foreground ,zenburn-blue+1 :weight bold))))
  (eshell-ls-executable ((t (:foreground ,zenburn-red+1 :weight bold))))
  (eshell-ls-unreadable ((t (:foreground ,zenburn-fg))))

• (eshell-ls-missing ((t (:inherit font-lock-warning))))
  

• (eshell-ls-product ((t (:inherit font-lock-doc))))
  

• (eshell-ls-missing ((t (:inherit font-lock-warning-face))))
  

• (eshell-ls-product ((t (:inherit font-lock-doc-face))))
  

  (eshell-ls-special ((t (:inherit zenburn-strong-1-face))))
  (eshell-ls-symlink ((t (:foreground ,zenburn-cyan :weight bold))))

@@ -207,17 +207,17 @@
(erc-action-face ((t (:inherit erc-default-face))))
(erc-bold-face ((t (:weight bold))))
(erc-current-nick-face ((t (:inherit zenburn-strong-1-face))))

• (erc-dangerous-host-face ((t (:inherit font-lock-warning))))
  

• (erc-dangerous-host-face ((t (:inherit font-lock-warning-face))))
  

  (erc-default-face ((t (:foreground ,zenburn-fg))))

• (erc-direct-msg-face ((t (:inherit erc-default))))
  

• (erc-error-face ((t (:inherit font-lock-warning))))
  

• (erc-fool-face ((t (:inherit erc-default))))
  

• (erc-highlight-face ((t (:inherit hover-highlight))))
  

• (erc-direct-msg-face ((t (:inherit erc-default-face))))
  

• (erc-error-face ((t (:inherit font-lock-warning-face))))
  

• (erc-fool-face ((t (:inherit erc-default-face))))
  

• ;; (erc-highlight-face ((t (:inherit hover-highlight-face))))
  

  (erc-input-face ((t (:foreground ,zenburn-yellow))))
  (erc-keyword-face ((t (:inherit zenburn-strong-1-face))))
  (erc-nick-default-face ((t (:weigth bold))))
  (erc-my-nick-face ((t (:foreground ,zenburn-red :weigth bold))))

• (erc-nick-msg-face ((t (:inherit erc-default))))
  

• (erc-nick-msg-face ((t (:inherit erc-default-face))))
  

  (erc-notice-face ((t (:foreground ,zenburn-green))))
  (erc-pal-face ((t (:foreground ,zenburn-orange :weight bold))))
  (erc-prompt-face ((t (:inherit zenburn-strong-2-face))))
  @@ -231,12 +231,12 @@
  (gnus-group-mail-2-empty-face ((t (:inherit gnus-group-news-2-empty))))
  (gnus-group-mail-3-face ((t (:bold t :inherit gnus-group-mail-3-empty))))
  (gnus-group-mail-3-empty-face ((t (:inherit gnus-group-news-3-empty))))

• (gnus-group-mail-4-face ((t (:bold t :inherit gnus-group-mail-4-empty))))
  

• (gnus-group-mail-4-empty-face ((t (:inherit gnus-group-news-4-empty))))
  

• (gnus-group-mail-5-face ((t (:bold t :inherit gnus-group-mail-5-empty))))
  

• (gnus-group-mail-5-empty-face ((t (:inherit gnus-group-news-5-empty))))
  

• (gnus-group-mail-6-face ((t (:bold t :inherit gnus-group-mail-6-empty))))
  

• (gnus-group-mail-6-empty-face ((t (:inherit gnus-group-news-6-empty))))
  

• ;; (gnus-group-mail-4-face ((t (:bold t :inherit gnus-group-mail-4-empty))))
  

• ;; (gnus-group-mail-4-empty-face ((t (:inherit gnus-group-news-4-empty))))
  

• ;; (gnus-group-mail-5-face ((t (:bold t :inherit gnus-group-mail-5-empty))))
  

• ;; (gnus-group-mail-5-empty-face ((t (:inherit gnus-group-news-5-empty))))
  

• ;; (gnus-group-mail-6-face ((t (:bold t :inherit gnus-group-mail-6-empty))))
  

• ;; (gnus-group-mail-6-empty-face ((t (:inherit gnus-group-news-6-empty))))
  

  (gnus-group-mail-low-face ((t (:bold t :inherit gnus-group-mail-low-empty))))
  (gnus-group-mail-low-empty-face ((t (:inherit gnus-group-news-low-empty))))
  (gnus-group-news-1-face ((t (:bold t :inherit gnus-group-news-1-empty))))
  @@ -246,11 +246,11 @@
  (gnus-group-news-5-face ((t (:bold t :inherit gnus-group-news-5-empty))))
  (gnus-group-news-6-face ((t (:bold t :inherit gnus-group-news-6-empty))))
  (gnus-group-news-low-face ((t (:bold t :inherit gnus-group-news-low-empty))))

• (gnus-header-content-face ((t (:inherit message-header-other))))
  

• (gnus-header-from-face ((t (:inherit message-header-from))))
  

• (gnus-header-name-face ((t (:inherit message-header-name))))
  

• (gnus-header-newsgroups-face ((t (:inherit message-header-other))))
  

• (gnus-header-subject-face ((t (:inherit message-header-subject))))
  

• (gnus-header-content-face ((t (:inherit message-header-other-face))))
  

• (gnus-header-from-face ((t (:inherit message-header-from-face))))
  

• (gnus-header-name-face ((t (:inherit message-header-name-face))))
  

• (gnus-header-newsgroups-face ((t (:inherit message-header-other-face))))
  

• (gnus-header-subject-face ((t (:inherit message-header-subject-face))))
  

  (gnus-summary-cancelled-face ((t (:foreground ,zenburn-orange))))
  (gnus-summary-high-ancient-face ((t (:foreground ,zenburn-blue))))
  (gnus-summary-high-read-face ((t (:foreground ,zenburn-green :weight bold))))
  @@ -302,7 +302,7 @@
  (magit-branch ((t (:inherit zenburn-strong-2-face))))

  ;; message-mode

• (message-cited-text-face ((t (:inherit font-lock-comment))))
  

• (message-cited-text-face ((t (:inherit font-lock-comment-face))))
  

  (message-header-name-face ((t (:foreground ,zenburn-green+1))))
  (message-header-other-face ((t (:foreground ,zenburn-green))))
  (message-header-to-face ((t (:inherit zenburn-strong-1-face))))
  @@ -312,7 +312,7 @@
  (message-header-subject-face ((t (:inherit zenburn-strong-2-face))))
  (message-header-xheader-face ((t (:foreground ,zenburn-green))))
  (message-mml-face ((t (:inherit zenburn-strong-1-face))))

• (message-separator-face ((t (:inherit font-lock-comment))))
  

• (message-separator-face ((t (:inherit font-lock-comment-face))))
  

  ;; mew
  (mew-face-header-subject ((t (:foreground ,zenburn-orange))))

[pchalasani]

I still have this problem: when I have (load-theme 'zenburn) in my init.el file, the zenburn looks fine, but when I try to do M_x color-theme-select I still get the font-lock-warning error with a blank buffer. Any advice on how to resolve this? I'm using the latest Emacs-24 and starting emacs the usual way in daemon mode, and calling emacsclient -c. I didn't quite understand the fix in the previous comment

[bo0ts]

I also run an Emacs server but it hardly seems related to the issue. My crudely formatted patch in the previous post fixed the issue for me. Sorry for the bad form. Maybe I can get it to you as a pull request tomorrow.

[pchalasani]

Actually I've decided it's not a big deal that the color-theme-select isn't working -- I didn't quite like most of the available themes anyway, so it's not so urgent. RIght now I've got sucked into figuring out another problem -- I can't seem to get shift-select-mode to work correctly, i.e. when I hold down the Shift key and move the up/down arrows, I expect a region to be highlighted and defined, but it just doesn't do it. I have shift-select-mode set to t.... I know this probably has nothing to do with zenburn whatsoever.

[bradyt]

If I execute color-theme-select, then load-theme zenburn, I don't get bug.

If I execute load-theme zenburn, then color-theme-select, I get bug.

(bug = Invalid face: erc-default.)

(In particular, I like to have (load-theme 'zenburn t) in my init.el file.)

I have not tried long code above yet, just reporting that default behavior still includes such.

[mlt]

Is this bug back? I'm getting that Invalid face: erc-default when running M-x org-html-htmlize-generate-css RET.

I'm using GNU Emacs 25.0.50.1 (x86_64-w64-mingw32) of 2015-02-17 on KAEL with Org-mode version 8.2.10 (8.2.10-35-g19a7d6-elpa @ c:/Users/user/Dropbox/Personal/emacs/.emacs.d/elpa/org-20150316/). Zenburn is from ELPA (Package-Version: 20150315.1540).

P.S.I have no color-theme-select function.

[mlt]

I feel like occurrences of erc-default in this theme shall be replaced with erc-default-face. Also it seems complaining afterwards on message-header-from as referenced from gnus-header-from. Perhaps that can be replaced with -to. Something like the following will let org-html-htmlize-generate-css work.

--- zenburn-theme.el.orig   2016-01-19 16:16:31.950007600 -0600
+++ zenburn-theme.el    2016-02-03 18:30:22.199526500 -0600
@@ -385,15 +385,15 @@
    `(erc-current-nick-face ((t (:foreground ,zenburn-blue :weight bold))))
    `(erc-dangerous-host-face ((t (:inherit font-lock-warning-face))))
    `(erc-default-face ((t (:foreground ,zenburn-fg))))
-   `(erc-direct-msg-face ((t (:inherit erc-default))))
+   `(erc-direct-msg-face ((t (:inherit erc-default-face))))
    `(erc-error-face ((t (:inherit font-lock-warning-face))))
-   `(erc-fool-face ((t (:inherit erc-default))))
+   `(erc-fool-face ((t (:inherit erc-default-face))))
    `(erc-highlight-face ((t (:inherit hover-highlight))))
    `(erc-input-face ((t (:foreground ,zenburn-yellow))))
    `(erc-keyword-face ((t (:foreground ,zenburn-blue :weight bold))))
    `(erc-nick-default-face ((t (:foreground ,zenburn-yellow :weight bold))))
    `(erc-my-nick-face ((t (:foreground ,zenburn-red :weight bold))))
-   `(erc-nick-msg-face ((t (:inherit erc-default))))
+   `(erc-nick-msg-face ((t (:inherit erc-default-face))))
    `(erc-notice-face ((t (:foreground ,zenburn-green))))
    `(erc-pal-face ((t (:foreground ,zenburn-orange :weight bold))))
    `(erc-prompt-face ((t (:foreground ,zenburn-orange :background ,zenburn-bg :weight bold))))
@@ -500,7 +500,7 @@
    `(gnus-group-news-6 ((t (:bold t :inherit gnus-group-news-6-empty))))
    `(gnus-group-news-low ((t (:bold t :inherit gnus-group-news-low-empty))))
    `(gnus-header-content ((t (:inherit message-header-other))))
-   `(gnus-header-from ((t (:inherit message-header-from))))
+   `(gnus-header-from ((t (:inherit message-header-to))))
    `(gnus-header-name ((t (:inherit message-header-name))))
    `(gnus-header-newsgroups ((t (:inherit message-header-other))))
    `(gnus-header-subject ((t (:inherit message-header-subject))))
@@ -779,7 +779,6 @@
    `(message-header-name ((t (:foreground ,zenburn-green+1))))
    `(message-header-other ((t (:foreground ,zenburn-green))))
    `(message-header-to ((t (:foreground ,zenburn-yellow :weight bold))))
-   `(message-header-from ((t (:foreground ,zenburn-yellow :weight bold))))
    `(message-header-cc ((t (:foreground ,zenburn-yellow :weight bold))))
    `(message-header-newsgroups ((t (:foreground ,zenburn-yellow :weight bold))))
    `(message-header-subject ((t (:foreground ,zenburn-orange :weight bold))))

[bbatsov]

@mlt PR welcome. :-)