Code snippet generates a `java:MethodDeclaration` in semantic mode about java-driver

[bzz]

Issue description updated to include short example.

[creachadair]

Specifically this method:

  public Scope scope(final String name) {
    return block(asyncBucket.scope(name)
      .thenApply(asyncScope -> new Scope(asyncScope, asyncBucket.name()))
    );
  }

Repro link: http://play.bblf.sh/daschl/d48c3ad4995ae9ec85f2888e0f2587ac/raw/36f03738ed1a5cbe5211f1999e46a3cf14c35b08/Bucket.java

[creachadair]

Here is a minimal repro:

package pkg;
public class C {
  public void method(final String str) {}
}

Specifically, removing the final keyword from the parameter declaration of method makes the problem go away.

[bzz]

Was rised in a community slack today again.

I'm going to look into this later this week, if @dennwc (who is assignee in this issue for now) is not fixing it earlier.

[bzz]

The issue is due to the fact that method argument modifiers array is always assumed to be nil, which is not the case when final is there.

Thus transformation MethodDeclaration -> uast:FunctionGroup does not happen for such cases.
Simples fix is to keep the same behavior of not preserving the modifiers but make the transformation happen.

Subsequent work should be done, introducing a proper schema for this case e.g by adding some extra node as discussed in bblfsh/sdk#361