GithubHelp home page GithubHelp logo

Comments (3)

dennwc avatar dennwc commented on July 29, 2024 2

we need to carry all the build environments for all languages in one container

This is not true. All you need to build a driver is to have Go 1.12+ locally and have access to Docker. It will re-create the environment there automatically.

bblfsh-performance should not perform build during the performance test

We want to test different branches and we won't ever have images published for those. We need to build it locally, there is no way around it. And it's not as hard as you may think.

from performance.

lwsanty avatar lwsanty commented on July 29, 2024

item 2. concerns me and I think it should be skipped
there're different drivers on different languages and for this case we need to carry all the build environments for all languages in one container with bblfsh-performance...

imo bblfsh-performance should not perform build during the performance test.
usage cases that I see:

  • CI execution: here we always gonna deal with driver images that are present in docker hub so no extra builds required
  • debugging by developer usually developer is able to create an image himself locally, then this image name can be passed to bblfsh-performance for an installation to bblfshd.

wdyt @dennwc @bzz @kuba-- @creachadair ?

from performance.

bzz avatar bzz commented on July 29, 2024

there're different drivers on different languages and for this case we need to carry all the build environments for all languages in one container with bblfsh-performance...

Build of language specific parts is hidden inside docker, so there is no need to do that, as @dennwc explain.

It may be ok to skip building in the beginning and make it would only with existing tags, but going further we would definitely want to be able to run it on random revision and that thus we need to plan/keep in mind the ability to build image by calling the docker.

from performance.

Related Issues (12)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.