Comments (4)
I could be wrong, but I think Primitive refers to a language builtin type (like integer, strings, et cetera, that is, not user defined types like classes) not keywords.
The native AST itself doesn't mark if an identifier is built in or not but we could certainly add the Primitive role to Num, String, Byte, Boolean, Set, Dict, List, Tuple and None nodes.
from python-driver.
Ok,
So there are two points:
- Extend the documentation string to be more specific about the role.
- Add Primitive role to nodes, where it is necessary.
The last one can be tricky because python has many built-in types (https://docs.python.org/3/library/stdtypes.html), and somewhere we can not check it. So, good idea to specify which types are Primitive for Python.
For example, as you said
Num, String, Byte, Boolean and None
from python-driver.
Note that I edited my message to add more.
I'm currently adding the primitive role to: Num (which include all numerical types), String, Byte, Boolean, Set, Dict, List and Tuple.
from python-driver.
Fixed by #110.
from python-driver.
Related Issues (20)
- unexpected EOF error for empty python files HOT 7
- Native driver cannot handle large files HOT 1
- check: key "returns": unused field(s) on node BoxedName: noops_sameline
- Should members of for loops have a "THEN" role? HOT 1
- annotated: quotes are not preserved HOT 1
- Alias error in imports [BUG] HOT 1
- Exception in variadic arguments
- Exception in function annotations HOT 1
- Inconsistent ordering of arguments if one is a keyword argument
- Object does not support item assignment HOT 1
- EOF in multiline statement
- 'unicodeescape' codec can't decode bytes
- Column out of bounds
- Overflow error
- Variable redeclared HOT 1
- I/O timeout
- Top-level node does not contain positions
- Roles are almost always empty HOT 12
- Prepending .. in relative imports HOT 4
- Empty position node in imports
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from python-driver.