GithubHelp home page GithubHelp logo

Comments (4)

juanjux avatar juanjux commented on July 29, 2024

I could be wrong, but I think Primitive refers to a language builtin type (like integer, strings, et cetera, that is, not user defined types like classes) not keywords.

The native AST itself doesn't mark if an identifier is built in or not but we could certainly add the Primitive role to Num, String, Byte, Boolean, Set, Dict, List, Tuple and None nodes.

from python-driver.

zurk avatar zurk commented on July 29, 2024

Ok,
So there are two points:

  1. Extend the documentation string to be more specific about the role.
  2. Add Primitive role to nodes, where it is necessary.
    The last one can be tricky because python has many built-in types (https://docs.python.org/3/library/stdtypes.html), and somewhere we can not check it. So, good idea to specify which types are Primitive for Python.
    For example, as you said

Num, String, Byte, Boolean and None

from python-driver.

juanjux avatar juanjux commented on July 29, 2024

Note that I edited my message to add more.

I'm currently adding the primitive role to: Num (which include all numerical types), String, Byte, Boolean, Set, Dict, List and Tuple.

from python-driver.

juanjux avatar juanjux commented on July 29, 2024

Fixed by #110.

from python-driver.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.