type of enums should not default to string about json-schema-to-typescript

[bcherny]

Fixed in 3773b24.

I'm not sure that foo: false is valid - can you point me to some reference material?

[donaldpipowitch]

What do you mean? Well you can take the schema and payload given in the first post and try it in an online validator.

[bcherny]

{
  "foo": false
}

Entering ^ in the validator you linked says that any value of foo is valid.

[donaldpipowitch]

I can't confirm that. For me, it looks like only false is valid and everything else is invalid:

[bcherny]

We're talking about different things. In your example above,

{
  "$schema": "http://json-schema.org/draft-04/schema#",
  "type": "object",
  "properties": {
    "foo": {
      "enum": [ false ]
    }
  }
}

This works as expected.

{
  "foo": false
}

This is not valid JSON-Schema.

I'm talking about the 2nd example.

[donaldpipowitch]

This is not valid JSON-Schema.

Why not? What is wrong? I can't spot an error.

[bcherny]

Ah, again we're misunderstanding each other. In the 2 code blocks in my comment above, you meant the 1st code block as the schema, the 2nd code block as the json to validate against that schema.

I thought you meant both as json schemas.

If that interpretation is correct, then your issue was fixed in the commit I linked above.

[donaldpipowitch]

Yeah, right. The left one (one the pictures) is the schema, the right one ({ "foo": false }) is the input JSON which is validated against the schema :)