Regression: API URL handling changed with release 1.1.0 about runitor

[Derkades]

Thank you for opening this issue, this explains why my checks are failing after updating to 1.1.0

[bdd]

This is a regression I should have caught. Sorry for the dumb breakage. As soon as I reach to the hotel, I'll cut a patch release, fixing use of new url.JoinPath function. P.S. Bummer, nobody ended up testing the beta release and reporting back either. GH follows should normaly notify new pre-releases but then again not many people follow it. I should consider creating an announce mailing list.

…

On Tue, Nov 22, 2022, at 1:26 PM, Robin wrote: Thank you for opening this issue, this explains why my checks are failing after updating to 1.1.0 — Reply to this email directly, view it on GitHub <#75 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAACW7YF7J7RHHPSAHFUTK3WJU3CDANCNFSM6AAAAAASIIQ46E>. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[bdd]

Thanks for confirming.

Do you want this closed now or on final release?

I'll close it when 1.1.1 is out.

[GermanCoding]

All good, thanks for caring!

I do have GitHub release notifications on actually, but I often tend to ignore prereleases. I always feel like I won't have the time to manually test them properly, so I naturally tend to just rely on stable releases. Of course when everyone does that the prerelease becomes useless - a typical issue with these types of projects.

For the future I'm going to try and setup a beta/RC channel for runitor. I have recently setup a Debian package for runitor (https://github.com/GermanCoding/runitor) sourced from official releases (it actually just repackages the official binary so signatures are preserved - it's not build from source). Then I will look into running a few runitor beta's here and there.

[bdd]

This may take a couple more hours.
One of the YubiKeys I use for signing releases that I packed for travel seems to be dead.
An alternate solution is on the way.

[bdd]

@GermanCoding @Derkades @blackscreen
Can you please test the release at https://github.com/bdd/runitor/releases/tag/v1.1.1-rc.1 ?

[Derkades]

Thank you for your quick action! Especially considering your circumstances. Anyway, I have tested the release candidate and it appears to work (with the / suffix removed)

[GermanCoding]

Yes, I can also confirm that this fix works. In addition, the double slash is now also a single slash in both cases:

runitor 1.1.1-rc.1 behaviour:

HC_API_URL="https://healthchecks.example.com/ping/"
runitor --uuid foobar

generates final request URL:

https://healthchecks.example.com/ping/foobar?rid=runid (single slash)

HC_API_URL="https://healthchecks.example.com/ping" (no final slash)
runitor --uuid foobar

generates final request URL:

https://healthchecks.example.com/ping/foobar?rid=runid (also single slash)

In fact, any number of trailing slashes are coalesced into a single slash:

HC_API_URL="https://healthchecks.example.com/ping/////////////"
runitor --uuid foobar
https://healthchecks.example.com/ping/foobar?rid=runid

Do you want this closed now or on final release?

[bdd]

v1.1.1 is out.
Go module v1.1.0 retracted.

https://github.com/bdd/runitor/releases/tag/v1.1.1