Change deliver to deliver_now for delivering right away about bamboo

[paulcsmith]

The (potential) problem with deliver_later is that it doesn't necessarily deliver later. The deliver_later call could be done with a TaskSupervisor which will start delivery immediately, but does so in the background. Maybe that difference doesn't really matter in practice though and having deliver_later and deliver_now is a good distinction.

[gshaw]

Unless there is a good reason to use a different name I'd suggest leveraging what Rails is using and go with deliver_now.

[paulcsmith]

@gshaw I wasn't aware that Rails changed to deliver_now. I kind of like that so I think that might be fine. So deliver will use whatever strategy you decide and deliver_now will deliver immediately and wait for a response until it returns.

How does that sound?

[gshaw]

Rails went with deliver_now and deliver_later to match ActiveJob's perform_now and perform_later methods. I find those names are very explicit and easy to work with.
http://edgeapi.rubyonrails.org/classes/ActionMailer/MessageDelivery.html

[paulcsmith]

Thanks for the feedback @gshaw. I went with deliver_later and deliver_now