Combining an HC and non-HC theme doesn't work with "Toggle Light / Dark Theme"? about bearded-theme

[BeardedBear]

Hi !

I've had a look at the problem and I know where it's coming from.

When we create a theme for VSCode we can choose between 4 types of themes, (sets in package.json file) :

• light (vs)
• dark (vs-dark)
• high contrast dark (hc-black)
• high contrast light (hc-light)

(yes, it's completely inconsistent)

The problem is that hc-light has a lot of inconsistent behaviour, notably the fact that icon packs that specify icons for light themes behave like icons for dark themes, or certain CSS properties aren't applied in the same way (for example, the background of the active item in the activity bar). So I tried to work around the problem by specifying in my package.json that hc-light icons are considered hc-black icons.

This gives me 2 options:

• I fix the light themes in high contrast with the correct type (hc-light), in which case I end up with visual inconsistencies.
• I leave it as it is, and create issues in the vscode repository to list the problems they cause, and then I can fix the problem!

My slightly manic side can't resign itself to accepting the first solution, so I'm going to take some time this week to create issues to hopefully fix these inconsistencies in future versions of VSCode!

But thank you very much for pointing out the problem, like my work and for being so precise!

[chambliss]

Oh no 😂 I had a feeling it was something like that. It does seem like in general there is less robust support in code editors for light themes (and especially once contrast constraints come into the mix). No worries, I'll continue using my workaround until the situation improves.

Thanks for your quick response!