GithubHelp home page GithubHelp logo

Make stringify protected about assert HOT 6 CLOSED

beberlei avatar beberlei commented on August 15, 2024
Make stringify protected

from assert.

Comments (6)

mdavis1982 avatar mdavis1982 commented on August 15, 2024

Why do you need to subclass the Assertion class? I can't think of a valid use case for doing this.

from assert.

sagikazarmark avatar sagikazarmark commented on August 15, 2024

This contradicts with the readme:

https://github.com/beberlei/assert#your-own-assertion-class

The obvious answer: custom assertions.

from assert.

mdavis1982 avatar mdavis1982 commented on August 15, 2024

You can still use custom assertions without needing to access the stringify() method. I can't see a use case where you need to subclass the Assertion class and then access the stringify() method. What is the use case for this?

from assert.

sagikazarmark avatar sagikazarmark commented on August 15, 2024

Since this issue is about 6 months old, I don't recall the exact use case. However, I can imagine custom, complex assertion which uses that method. Since the whole Assertion class uses it, I don't think it's hard to find one custom use case. Any case, you want to do something with strings.

from assert.

mdavis1982 avatar mdavis1982 commented on August 15, 2024

I think we need to refer this back to @beberlei - but I'm not sure if changing it would have any other implications.

from assert.

beberlei avatar beberlei commented on August 15, 2024

this was done in some PR.

from assert.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.