GithubHelp home page GithubHelp logo

Comments (2)

BSVogler avatar BSVogler commented on July 18, 2024 1

I think it would be good when the bundle would behave identically to the client so that the code like this would work

bundle = client.resources('Bundle')
for patient in patientlist:
    bundle.resources("Patient").reference('Patient', user)
bundle.fetch_all()

as this is a special behavior it might also be good to have a special constructor like bundle = client.bundle() instead

from fhir-py.

ruscoder avatar ruscoder commented on July 18, 2024

We discussed in the team this issue and decided that Bundle isn't an ordinary resource as a Patient and etc. It is an abstract resource that can't be instantiated. So, it means we can use .delete(), is_valid() and the resource can't have an id.

Let's add a new class BundleResource (and appropriate AsyncBundleResource/SyncBundleResource and aidbox versions) and return it in client.resources('Bundle').

This class should provide an interface:

  • .save() - only if type = transaction/batch - should update the inner resource without changing bundle.type
  • .get_resources()/resources TBD
  • .set_resources()/resources TBD
  • .add_resources() TBD
  • get_resources_by_resource_type(resource_type)
  • get_resource_by_reference(reference)

Also, let's return the instance of this class in fetch_raw - it'll solve #17 partially

from fhir-py.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.