GithubHelp home page GithubHelp logo

Comments (2)

mkizesov avatar mkizesov commented on July 18, 2024

Some thoughts.

Operation on particular resource/reference

sdk.client.resource('Questionnaire', id=123).execute('$populate')
sdk.client.reference('Patient', 1).execute( ... )

async def execute(self, operation):
    pass

Operation on any path. In FHIR we can also use GET requests for operations (and there are some DELETE and PUT operations in Aidbox), but I think we should implement sdk.client.execute to work only with POST operations (because it's most common)

sdk.client.execute('/ValueSet/$expand', {'url': 'http://abc', 'filter': 'value'})

async def execute(path, payload, method?='post'):
    pass

# or using kwargs:
sdk.client.execute('/ValueSet/$expand', url='http://abc', filter='value')

async def execute(path, method?='post', **payload):
    pass

Also we can add public method for doing any requests with fhir-py aiohttp client. Something like:

sdk.client.request('post', '/Valuest/$expand', ...)

async def request(method, path, params=None, payload=None)
    pass

from fhir-py.

mkizesov avatar mkizesov commented on July 18, 2024

We decided that all methods should have similar set of params.
Execute on resources affects only request url.

sdk.client.resource('Questionnaire', id=123).execute('$populate', **kwargs)

sdk.client.execute('/ValueSet/$expand', **kwargs)

# kwargs: method, params, payload, etc..
# Probably they should be the same as in aiohttp request
# and should be passed to aiohttp request without any changes

from fhir-py.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.