GithubHelp home page GithubHelp logo

Comments (5)

sirbeefalot avatar sirbeefalot commented on July 1, 2024 1

Ok, fixed it. It looks much better now. Let me know what you think and if it's all good I can close this one.

from beefy-v2.

AllTradesz avatar AllTradesz commented on July 1, 2024

I'm afraid this fix stopped right-alignment of the values in the drop-down.
image
Presuming this wasn't intentional, shall I "fix" this, or would you prefer to, @sirbeefalot or @erenjaegar77 ?

from beefy-v2.

sirbeefalot avatar sirbeefalot commented on July 1, 2024

It was intentional as the values are not right aligned in the design reference. There's only a single space between label and value: https://www.figma.com/file/rM0nDDYA042Z4WpOdV0vf4/Deep-Work-x-Beefy

Screen Shot 2021-08-13 at 16 24 56

from beefy-v2.

AllTradesz avatar AllTradesz commented on July 1, 2024

Which begs the question, do we want to stick with that benchmark, or do you think right-aligning the result looks more appealing, showing more distinction and "roominess" between label and value? (Labels stay left-aligned, as they were before this fix, and before I came into the game.)

from beefy-v2.

sirbeefalot avatar sirbeefalot commented on July 1, 2024

I like it better like this tbh 😅

There is one problem though. Why does it look inverted on your screen? The labels are white and the values are dim on your screenshot. I think that's also why it looks a little off.

Edit: Oh, same thing on mine. That's why it's looking kinda bad, I'll fix it.

from beefy-v2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.