Comments (16)
Attaching patches for
1. making rtengine static library as I don't see a single reason why it should be
shared one
2. Make rt work in FHS compliant mode for system wide installation. This mode is
default on non Windows builds, but can be still turned off in case you want to
produce standalone binary package.
Reported by [email protected]
on 2010-01-18 13:07:21
- _Attachment: [0003-Make-rtengine-static-library.patch](https://storage.googleapis.com/google-code-attachments/rawtherapee/issue-30/comment-1/0003-Make-rtengine-static-library.patch)_
from rawtherapee.
Updated patch with forgotten config.h.in.
Reported by [email protected]
on 2010-01-18 14:06:31
- _Attachment: [0004-Add-support-for-FHS-compliant-system-wide-install.patch](https://storage.googleapis.com/google-code-attachments/rawtherapee/issue-30/comment-2/0004-Add-support-for-FHS-compliant-system-wide-install.patch)_
from rawtherapee.
Thank you!
Btw, for me it is fine if you commit those patches, instead of adding them here
apart, and here you simply write the release number. In any case, I'm building svn
sources, not from the targz of 3.0.
Reported by viriketo
on 2010-01-18 14:14:11
from rawtherapee.
I don't have commit access, that's why I'm just posting patches :-).
Reported by [email protected]
on 2010-01-18 14:18:19
from rawtherapee.
I think you should have. Wold be great have this patch in trunk.
Reported by Marian.Kyral
on 2010-01-24 13:59:11
from rawtherapee.
Could you submit the patch again against the current revision, please? I would like
to apply it. I really appreciate your contribution.
Reported by ghorvath.x
on 2010-01-31 20:31:31
from rawtherapee.
Attaching all current patches from my tree.
Reported by [email protected]
on 2010-02-01 08:38:54
- _Attachment: [rt-patches.tar.bz2](https://storage.googleapis.com/google-code-attachments/rawtherapee/issue-30/comment-7/rt-patches.tar.bz2)_
from rawtherapee.
xnijel;
We are now getting the infrastructure and procedures in place to better accept third
party patches. We thank you very much for your patch submissions earlier, and
apologize that we have not yet been able to implement them. If it is not too much
trouble, would you be able to re-generate this and the other patches based on the
current trunk? There have been a number of changes, especially to the build system,
and I am not confident enough with CMake to merge these files manually.
Let me know if you have any questions.
Cheers
Reported by wyatt.olson
on 2010-04-22 13:56:53
from rawtherapee.
I currently don't have time for this, but I will try to find time to check whether my
patches would be still needed
or not.
Reported by [email protected]
on 2010-04-22 14:27:39
from rawtherapee.
That would be wonderful, thank you very much!
Cheers
Reported by wyatt.olson
on 2010-04-22 14:49:43
from rawtherapee.
Issue 35 has been merged into this issue.
Reported by wyatt.olson
on 2010-04-24 17:33:49
from rawtherapee.
Issue 24 has been merged into this issue.
Reported by wyatt.olson
on 2010-04-24 17:34:05
from rawtherapee.
This is solved, isnt it?
Reported by [email protected]
on 2010-04-24 20:51:23
from rawtherapee.
Not sure; I know there was a complete overhaul of the cmake system, but I am not sure
how it is working on Linux at the moment. I know for Windows and OSX we (correctly)
install by default into a release/ folder within the source tree so that we can
bundle things, but Linux is different I believe.
If someone running Linux can verify this, that would be great and I can close this
ticket.
Cheers
Reported by wyatt.olson
on 2010-04-24 21:21:01
from rawtherapee.
Yes, I am using this under linux (Ubuntu 9.10).
I do
cmake -DCMAKE_INSTALL_PREFIX=./release -DBINDIR=. -DDATADIR=. -DLIBDIR=. .
and after that make install installs everything to release dir
If i do just
cmake .
it installs to system dirs. This is considered right behavior
Reported by [email protected]
on 2010-04-24 21:33:40
from rawtherapee.
Good enough for me. If anyone else notices a problem here, please let me know;
otherwise I will consider this fixed.
Cheers
Reported by wyatt.olson
on 2010-04-24 21:39:31
- Status changed:
Fixed
from rawtherapee.
Related Issues (20)
- B&W not working HOT 3
- Updated Dutch translation
- RawTherapee git: conflict file on Arch system HOT 2
- Bundle Adobe RGB / opRGB output profile? HOT 3
- Rawtherapee does not load HOT 8
- Possible Big Sur incompatibility? HOT 2
- Flat field is not applied HOT 1
- Crashes on launch, OS X 14.4 (23E214) iMac 3.7 GHz 6-Core Intel Core i5 HOT 4
- No vignette correction available for NIKON D5600 + AF-S DX Nikkor 35mm f/1.8G but it appears in lensfundb HOT 5
- All EXIF data selected after resetting history in Batch Edit HOT 23
- RT 5.10 is non-responsive when processing queue HOT 5
- RAWTherapee DJI mini 4 Pro DNG HOT 9
- Demosaiced DNGs fail to load since commit 831a9bbd HOT 1
- DNG OpcodeList3 GainMap support
- Documentation improvement - RawPedia replacement HOT 11
- Fujifilm GFX100II Image with RawTherapee does not render correctly when opened HOT 8
- Branch _lacam16n_ : Bad behaviour when resizing image HOT 1
- Support for Fujifilm EXR HR (High Resolution) mode HOT 1
- Automatic lens correction via lensfun does not work with Leica-SL2-S and Sigma L-mount lenses, manual selection works HOT 5
- Sony Alpha 9 III (ILCE-9M3) (ARW lossless compression) HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rawtherapee.