Comments (6)
Unlike #7045, the file is closed after it is done using it.
from rawtherapee.
I have new information on this.
I did a new debug build with the latest dev version 5.10-208 and ran it on valgrind. It seems like the issue of the locked file is related to the thumbnails. I did some more testing to make sure to narrow down the problem. Here are the added notes:
- The problem is reproducible if I open the RawTherapee in file browser and then open the source file to Save As jpeg.
- The issue is not reproducible if I open the file directly with RawTherapee from file manager.
- The issue still seems to exist only for the jpg files.
- Opening directories with jpg files and/or opening jpg file from such directory doesn't have issues.
- So far reproducible only after Save As has been used to generate a new jpg file.
I think this is the relevant part from the Valgrind result:
Details
==5290== at 0x7280705: open (in /usr/lib/libc.so.6)
==5290== by 0x720393E: _IO_file_open (in /usr/lib/libc.so.6)
==5290== by 0x7203AC4: _IO_file_fopen (in /usr/lib/libc.so.6)
==5290== by 0x71F7D5A: ??? (in /usr/lib/libc.so.6)
==5290== by 0xB420EA: rtengine::ImageIO::loadJPEG(Glib::ustring const&) (in /usr/local/bin/rawtherapee)
==5290== by 0xE871B0: rtengine::StdImageSource::load(Glib::ustring const&) (in /usr/local/bin/rawtherapee)
==5290== by 0xE5C0F8: rtengine::Thumbnail::loadFromImage(Glib::ustring const&, int&, int&, int, double, rtengine::StandardObserver, bool) (in /usr/local/bin/rawtherapee)
==5290== by 0x9B0A8F: Thumbnail::_generateThumbnailImage() (in /usr/local/bin/rawtherapee)
==5290== by 0x9B1CE5: Thumbnail::Thumbnail(CacheManager*, Glib::ustring const&, std::__cxx11::basic_string<char, std::char_traits, std::allocator > const&, std::__cxx11::basic_string<char, std::char_traits, std::allocator > const&) (in /usr/local/bin/rawtherapee)
==5290== by 0x4A824A: CacheManager::getEntry(Glib::ustring const&) (in /usr/local/bin/rawtherapee)
==5290== by 0x91734F: PreviewLoader::Impl::processNextJob() (in /usr/local/bin/rawtherapee)
==5290== by 0x5E04F41: (anonymous namespace)::call_thread_entry_slot(void*, void*) (slot.h:540)
from rawtherapee.
I tested and turning the file descriptor at
RawTherapee/rtengine/imageio.cc
Line 483 in e316e87
from rawtherapee.
That code is in the JPEG file reading function. Did you save the JPEG in the directory that is open in the RawTherapee file browser?
from rawtherapee.
That code is in the JPEG file reading function. Did you save the JPEG in the directory that is open in the RawTherapee file browser?
Yes. Right next to the source file.
I now tested creating a subdirectory for the open directory and when saved there, there was no locking issue. The option to show images recursively in subdirectories was not enabled. After enabling the recursive option, the locking happened in the subdirectory as well.
from rawtherapee.
Ok, it makes sense now why the freeze is happening.
from rawtherapee.
Related Issues (20)
- History is getting spammed when Color Appearance & Lighting module is enabled Build 5.10-190 on dev branch. HOT 8
- A gamma shift issue/color change after saving to jpg HOT 1
- No DateTime (= editing date) in EXIF data of exported photo
- Please support Rust-free `librsvg` HOT 4
- JPG Export best-quality really chroma subsampling 4:4:4 ? HOT 1
- Film Negative - Improper assumption of mapping between raw values and transmission coefficient HOT 11
- RawTherapee 5.10 not responsive after start HOT 4
- Am I misunderstanding TP_LOCALLAB_AVOIDCOLORSHIFT_TOOLTIP? HOT 3
- Feature request: export pictures in HEIF 10bit HOT 3
- The GUI doesn't open on first install (Windows). HOT 1
- Wavelets - malfunction for the “selective range” part HOT 1
- Program resources not loaded when installed in directory with special characters HOT 7
- Build fails with libjpeg-turbo 3.0.3: Undefined symbols for architecture x86_64: "_jpeg_std_message_table" HOT 12
- Sony ILCE-6700 has invalid pixels on the right border HOT 1
- Chinese (Simplified) translation (intended for) Rawtherapee 5.8 (or 5.9?) HOT 1
- Please consider implementing a better way to preview and scroll through presets HOT 1
- Update GUI in Japanese HOT 1
- Add/Edit Exif not possible, if Exif data is not available in photo HOT 3
- Assertion '__n < this->size()' failed. HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rawtherapee.