GithubHelp home page GithubHelp logo

Comments (5)

thom8 avatar thom8 commented on May 18, 2024

My preference would be to remove xhprof from the defaults until the PR is merged upstream.

from beetbox.

Decipher avatar Decipher commented on May 18, 2024

Agreed.

However, currently the PR I made for XHProf needs work as it is failing tests; It appears there's a false negative where if no version is detected (eg, it needs to be installed) the test is failing rather than installing XHProf.

from beetbox.

Decipher avatar Decipher commented on May 18, 2024

Merged a temporary removal of XHProf from the base box (won't come into play until the next build).

Have also updated the PR (geerlingguy/ansible-role-php-xhprof#2) so that it should now pass the tests.

from beetbox.

oxyc avatar oxyc commented on May 18, 2024

I believe this should be fixed upstream as soon as Centos 6 starts behaving and this PR gets merged: geerlingguy/ansible-role-php-xhprof#12

from beetbox.

thom8 avatar thom8 commented on May 18, 2024

Thanks @oxyc!

@Decipher looks like we can add this back into the defaults.

from beetbox.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.