How to create method Trades (like Time(), Assets(), etc) about kraken-go-api-client

[beldur]

Yes looks good!

PR appreciated ☀️

[beldur]

I added the Trades Call as an API Method: 7dcae7a

For usage you can look into the test method.

Does this answer your question?

[Glavic]

Nice.
I created small modification. What do you think? Should I make PR?
https://github.com/Glavic/kraken-go-api-client/commits/master

[Glavic]

Hi, me again.
Just thinking that float is not a good variable for storing sensitive information like Price, Volume and Time in Trades() function. Kraken returns strings (and for a good reason) and u convert it to float64 :(
We could solve this problem with Rational struct (RAT) or plug-in like this: https://github.com/shopspring/decimal
Whay say u?

[beldur]

Hi,

I'm a bit reluctant to add a dependency to another package, but I agree that float is the wrong type. Maybe we can use int? The number of decimals can be queried from Kraken Assets API call.

What do you think?

[rikonor]

Sorry to barge in but, out of curiosity, what's wrong with keeping it as floats?

…

On Sun, May 28, 2017, 9:06 AM Alexander Lücking ***@***.***> wrote: Hi, I'm a bit reluctant to add a dependency to another package, but I agree that float is the wrong type. Maybe we can use int? The number of decimals can be queried from Kraken Assets API call. What do you think? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#3 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADPQNmElNumUi9VPE0CfOKizrcMmZOWWks5r-XFkgaJpZM4NmHZN> .

[beldur]

I quote here directly from the decimal project:

Because float64s (or any binary floating point type, actually) can't represent numbers such as 0.1 exactly.
Consider this code: https://play.golang.org/p/TQBd4yJe6B

[Glavic]

I agree that using other plug-ins isn't great idea; I just linked it if there is some idea to "borrow"...
Are u thinking of running Assets() every time Trades() is called? Or we could just use max decimals for all assets (for example 10)? Just hope that int64 will be enough.

[Glavic]

For Time we could just use μs.

[beldur]

If you call Assets for Trades you are in danger of messing up rate limiting tracking for consumers of the API. (Kraken Rate Limiting)

So I would keep the responsibility to the API consumer to know that eg. EUR has to be divided by 5 (197001100 / 5 = 1970.011 EUR) while JPY has to be divided by 3 (261531900 / 3 = 261531.9 JPY).

Another option would be to change the type to string and let the consumer decide how to deal with it.

[Glavic]

So I would keep the responsibility to the API consumer to know that eg. EUR has to be divided by 5 (197001100 / 5 = 1970.011 EUR) while JPY has to be divided by 3 (261531900 / 3 = 261531.9 JPY).

But how will u know in Trades() how much decimals has EUR or JPY? I would not go into hardcoding those values, since they can change in the future...

On other hand, more than I think about it, it would be better to let API consumer decide what to do with the data received from Kraken API...

[beldur]

On other hand, more than I think about it, it would be better to let API consumer decide what to do with the data received from Kraken API...

I updated the code accordingly 0d429b8

[Glavic]

I would leave it as it is, only string; and let consumer do the magic with it :)