bendr / bender Goto Github PK

The did_render of the parent is called before the did_render of children, that is wrong.
=> parent.did_render can not manipulate his children.

Hi!

I've just found Bender, and it is almost exactly the same framework I wanted to create. Well, actually, better than that :)

A question: I'd like to use gradients and filters in SVG, but I need to use id attributes to refer to them. However, it seems to me that all id attributes are removed. How can I use gradients then?

Another question: is there a way to include external svg files, without copy-pasting them into the component xml files?

Thx!

Bernát

Instances of second generation of children are not visible within did_render function.
For instance if you have this tree:

<c id="c1">
  <c id="c2">
    <c id="c3" />
  </c>
</c>

c1.did_render has access to c2 but not to c3 (this.instances.c2 is OK but this.instances.c3 is NULL)
And this.instances.c2.instances.c3 is also NULL.

The bug is visible in Nibbler, Widgets demos, function "bender.$.Widgets.did_render" Widgets.js:5

The properties are not visible/ initialized for the root component.

Example:

<component xmlns="http://bender.igel.co.jp" href="../lib/ui/Application.xml"
  id="buttons"  layout="absolute_layout">
....

</component>

Within the function "did_render" of Application component, the property layout is not visible.
See the Nibbler demo Buttons.html, nibbler.js:202, "instance.properties.layout" is null whereas it should contain the string "absolute_layout".

Let use this specification:

<c id=c1 href=c2 />
<c id=c2>
  <c href=Button />
</c>

When this spec is rendered you have the following DOM witch is what you want:

<c1>
  <c2>
    <button />

But if you add a component into c1, ex:

<c id=c1 href=c2>
  <c href=List />
</c>
<c id=c2>
  <c href=Button />
</c>

You obtain this DOM that is not what you expect, because the button disappear:

<c1>
  <c2>
    <list />

The right DOM should be some thing like:

<c1>
  <c2>
    <button />
    <list />

The bug is visible with Nibbler, ToDo.
The function "nibbler.core.Array.did_render" nibbler.js:112 is never called.