Comments (16)
Gentlemen [ @benedekrozemberczki and @GiulioRossetti @WhatTheFuzz @gkirgizov ] please check out #150 🥳
Everything works in networkx 3.3 now! All unit tests pass. Please examine and merge 😁
from karateclub.
I got a little experience in this PR: benedekrozemberczki/littleballoffur#23
I am going to make karateclub
go with networkx>=3.1
now :)
from karateclub.
Closing issue as PR was merged.
from karateclub.
Hi @GiulioRossetti , I will look into this.
from karateclub.
I can confirm that networkx
3.0 < makes breaking changes, as shown in the test cases.
FAILED test/community_detection_overlapping_test.py::test_danmf - ValueError: inconsistent shapes
====================== 1 failed, 46 passed, 851 warnings in 195.31s (0:03:15) =======================
This may be related to the change networkx
3.0 < made to return sparse arrays instead of matrices when calling certain methods. See one deprecation warning below.
test/community_detection_overlapping_test.py::test_danmf
test/community_detection_overlapping_test.py::test_danmf
/home/siuser/Developer/karateclub/karateclub/community_detection/overlapping/danmf.py:48: FutureWarning: adjacency_matrix will return a scipy.sparse array instead of a matrix in Networkx 3.0.
self._A = nx.adjacency_matrix(
To recreate this issue, just bump networkx
dependency in setup.py
to "networkx==3.0",
from karateclub.
I need pandas 2.0. I can't use this :( Ed: Ok, this is an exaggeration :)
from karateclub.
@WhatTheFuzz can you let me know what other issues involving networkx 3.0 are? I really want to include karateclub
in my Graph ML class and am willing to do the work if it isn't too extensive.
from karateclub.
Ok, FWIW I am poking around here :)
install_requires = [
"numpy>=1.22.0",
"networkx>=3.0",
"decorator==5.1.*",
...
from karateclub.
Sorry, I didn't mean to leave you hanging! I was just going off of the unit tests before. I'm not exactly the best ML dev out there. I would definitely love to bump the dependencies so I can update my environments. Happy to bounce ideas off though.
from karateclub.
Oh, no problem! I just kind of jumped on it :)
from karateclub.
Hi there @rjurney do you want to go ahead?
from karateclub.
As I see, in https://github.com/benedekrozemberczki/karateclub/blob/master/setup.py you have already relaxed requirements. But PyPi release still has quite strict requirements that get in the way with almost any other recent package. We got into install problem because of that in our project https://github.com/aimclub/GOLEM.
Could you consider making a minor release soon with updated dependencies?
from karateclub.
@gkirgizov I am going to get back to this soon!
from karateclub.
I am now to the point where my class starts Monday. I am looking at this.
from karateclub.
Oh shit, this is that scikit-learn bug I ran into :( Woe is me, I've got just half an hour to try!
from karateclub.
@LucaCappelletti94 much gracias!
from karateclub.
Related Issues (20)
- Estimator _check_graph method
- g2vec_model.infer([test_graph]) returns different embeddings each time I call it HOT 2
- IGE Laplacian Issue for small graphs HOT 1
- gl2vec doc’s may be inconsistent with the code HOT 4
- Does GraRep change the input graph ? HOT 3
- How are ego-nets created
- cannot import name '_rename_parameter' from 'scipy._lib._util' HOT 6
- Inductive Node Embedding Algorithms in KarateClub HOT 2
- numpy version error HOT 10
- How to retrieve the mapping between nodes and embeddings with get_embedding() ? HOT 1
- Seed and random results for embeddings HOT 1
- Add set_params to Estimator base class
- Pandas version
- AssertionError: The node indexing is wrong. HOT 4
- [Graph2Vec] the right way to build the attributed graph... HOT 1
- Graph2Vec—— how the attributed nodes are transformed to subgraph and word?
- GLEE - the sign of embedding values changes for repeat fits
- Feather-Graph with attributed graphs
- Cut new release 1.3.4 [or 1.4.0?] HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from karateclub.