argparse functionality broken by 76a4328 about jobtree

[benedictpaten]

;) Can we not just substitute the default string to avoid having to
replicate arguments?

On Wed, Nov 20, 2013 at 12:49 PM, Dent Earl [email protected]:

Commit 76a4328 76a4328bdbroke argparse functionality by failing to maintain the new method of
displaying default values in help strings. The old, optparse method is to
use

help="blah blah blah default=%default"

and the argparse method, is to use

help="blah blah blah default=%(default)s"

The two methods are incompatible with one another, which was why we had
two methods to handle this.

76a432876a4328

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/17
.

[dentearl]

I could see something like

if isinstance(addOptionFn, WhateverClassIsArgparseGroup):
  default_str = '%(default)s'
else:
  default_str = '%default'

And then having your help be like

... help='blah blah blah default=%s' % default_str)

But I haven't actually tested that, so I'm not sure it'll work but it's the first thing that pops into my head.

[benedictpaten]

If that's the issue it should work. Do you want me to do it? I did break it.

On Wed, Nov 20, 2013 at 1:17 PM, Dent Earl [email protected] wrote:

I could see something like

if isinstance(addOptionFn, WhateverClassIsArgparseGroup):
default_str = '%(default)s'else:
default_str = '%default'

And then having your help be like

... help='blah blah blah default=%s' % default_str)

But I haven't actually tested that, so I'm not sure it'll work but it's
the first thing that pops into my head.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/17#issuecomment-28931803
.

[dentearl]

Yes please :)

I think the only tricky part will be figuring out the correct class for the isinstance call

[benedictpaten]

Fixed