strncpy error in VS2013 about inih

[benhoyt]

Hmm, interesting. I believe my use of strncpy here is actually safe. What's the typical solution for this? #if to check if you're compiling on Windows, and use strncpy_s or something if so, otherwise regular strncpy?

[AgostinoSturaro]

I've researched this, it seems to be VS2013 (and VS2012) complaining about simple things like fopen as well, suggesting to use the _s versions defined in TR 24731, which is an optional extension of C11.
There's this option to silence it without raising the _CRT_SECURE_NO_WARNINGS flag everywhere.

BTW I'm using the cpp wrapper. What happens if the ini file is malformed? Can I detect that with reader.ParseError() right after having initialized the reader with INIReader reader("path")?

Thanks.

[andravin]

@benhoyt yes, and identify windows with #ifdef _WIN32

[cremno]

@benhoyt: Yes, it's safe here. A solution could be for users to define _CRT_SECURE_NO_WARNINGS (with /D or #define) by themselves. You could also do it for them.

@AgostinoSturaro: You're mistaken. MS doesn't implement those C11 functions (yet). There are many differences between them.

@andravin: This has nothing to do with Windows itself. There are also other C compilers and standard libraries for Windows.

[andravin]

OK, if the strncpy warning is MSVC only, then instead of checking for MS Windows with #ifdef _WIN32, you can check for the MSVC compiler using #ifdef _MSC_VER

I don't think requiring the user to define _CRT_SECURE_NO_WARNINGS is an acceptable solution.

[cremno]

@andravin:

You could also do it for them.

That's only one line (#define _CRT_SECURE_NO_WARNINGS) he has to add before the #include directives in ini.c

[benhoyt]

Okay, I'm happy to add this to ini.c -- I'll do this in the next few days:

#ifdef _MSC_VER
#define _CRT_SECURE_NO_WARNINGS 1
#endif

[benhoyt]

I don't have ready access to MSVC right now -- can someone please try adding the above #ifdef dance before the #includes in ini.c and ensure the warning goes away? If so, feel free to send a pull request.

[benhoyt]

Fixed in c3458c9 and created release r31 with fix: https://github.com/benhoyt/inih/releases/tag/r31