GithubHelp home page GithubHelp logo

Comments (7)

crazy-matt avatar crazy-matt commented on May 24, 2024 1

Or putting in the README as a step example something like:

 - name: "Temporarily disable 'include administrators' default branch protection"
        uses: benjefferies/[email protected]
        if: always()
        with:
          access-token: ${{ secrets.ACCESS_TOKEN }}
          branch: ${{ github.event.repository.default_branch }}

which catch the attention straight away

from branch-protection-bot.

benjefferies avatar benjefferies commented on May 24, 2024

I'm happy to accept a PR that will automatically create branch protection rules as this is an issue when master branch doesn't have branch protection. The only requests I would have is:

  • Default branch pattern is set to master
  • Handles the case where the branch protection already exists
  • Backwards compatible

What advantage do you see in deleting branch protection over disabling?

from branch-protection-bot.

amacado avatar amacado commented on May 24, 2024

What advantage do you see in deleting branch protection over disabling?

How do you disable a branch protection? I don't see an option for that..

from branch-protection-bot.

benjefferies avatar benjefferies commented on May 24, 2024

Sorry I meant disabling 'include administrators'

from branch-protection-bot.

crazy-matt avatar crazy-matt commented on May 24, 2024

Hi guys,
I wonder if you shouldn't put the default branch as being 'main'. As the new repos are now created with main as a standard on Github. But nothing important really.

from branch-protection-bot.

crazy-matt avatar crazy-matt commented on May 24, 2024

Otherwise, I just loved the idea of this action to handle a situation that Github does not want to handle at the moment probably for security implications. Tested it and it does the job like a charm! Thanks @benjefferies for that

from branch-protection-bot.

benjefferies avatar benjefferies commented on May 24, 2024

Thanks for the suggestions @crazy-matt #22

from branch-protection-bot.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.