q5go doesn't save layout properly about q5go

[bernds]

Try saving the specific layout? I think the general default may just set window size/position. Maybe I should remove that option.
I wasn't able to reproduce the sidebar issue in a quick test.

[nsklaus]

for the sidebar, please look at this screenshot, you can see the sidebar is not enabled in menu, but it is actualy being shown in game window.

in this case i'm not even connected to igs. but it is the same when on igs.

[nsklaus]

i see two options to save the layout, and i did them both. but that did not properly save the layout.
observer bar is always coming back. and it is the same for slider bar.
you can see on previous post's screenshot: slider, sidebar and status bar are displayed, despite being unchecked.

[bernds]

EDIT: Removed a suggestion to attach the q5gorc file. This should not be done as it contains passwords.
I can reproduce this for the slider (and I think I can partially see how that happens), but not the side bar. Is this happening in a normally opened board window, not just an online one? What happens when you toggle sidebar visibility in that state?

[bernds]

Actually, don't. It contains passwords. You should remove all the HOST entries if you do want to paste it.

[bernds]

I think I'm locking the conversation for a while to make sure you read the previous comment and don't accidentally post an unsanitized file.

[nsklaus]

(thank you for the warning about sanitizing debug and config files)

about the sidebar, when it is visible on screen despite being checked "off",
if i click to check it "on" then nothing happen the first time (since it's already being shown).
then aftwards it works normaly. "off" would remove it, and "on" would bring it back.
this problem exist on all game windows, online or offline. i also see the same kind of things for observer bar.

i will test again and report after a few hours, i made many games i need to take a pause for the moment. i think i will delete my local configuration and test from fresh, make a few screenshots i'll make the log from beginning and then report back.

[nsklaus]

ok, i made a test from fresh state (removed my old q5gorc file).
i made 3 connection to igs. each time i saved the layout i wanted.
i made 4 screenshots.
for screenshot 2 and 3, i saved my layout ( i click save layout a few times ) then exited completly q5go. for screenshot 4 i just launched a new game without exiting q5go.

• the first screenshot shows plain default situation right after login in, starting a game i took a screenshot but i didn't change anything. you can see there's already a problem.
• the 2nd one is how i want my layout to be.
• 3rd and 4th ones shows my layout isn't being correctly applied.

you can see it does not correspond to the layout i've chosen and saved as in screenshot2.
also

there is the 3 sessions log files and my fresh q5gorc attached. (the archive is tgz, i just renamed it to .zip so github accepts it)
q5go_layout.zip

(sorry i had made a mistake with the archive, screenshot1 wasn't available, i reuploaded now)

[bernds]

Ok, I can now see how the "side bar is shown but unset in View" can occur when there is no saved layout. The menu item is checked/unchecked when restoring the layout. That's fixable. But I thought the issue also happened if you had a saved layout - can you clarify?

[bernds]

I think the sidebar issue is fixed now, but I'm still somewhat confused.

The observer thing is different, that is just enabled by default for all on-line games and not saved anywhere. It doesn't really fit with the "save layout" bit, since that saves per combination of docks - so observers on/off are two different layouts.
Maybe there should be a preferences option to disable showing it.

[nsklaus]

ok there was a few commits between the different issues, i grab fresh source to try it all.
it seems better now. only observer bar that keeps coming back. as you were saying.
the rest of the layout seems to be better in sync with what is being checked in the ui, and saved.
i need to test a bit longer, but first impression feels like it's better now.

[nsklaus]

i confirm, most of the layout is behaving fine now. there is only the observer bar that keeps coming back. as you've hinted at earlier. most of the ui layout settings remember saved state now, and seems well in sync with what's being shown as checked in the menus.

[nsklaus]

i'm closing this issue, as the layout is properly saved now. i'll open a separate issue for the observer bar that keeps coming back. many thanks for the work done. it is very appreciable, not having to setup layout every time i open q5go.