GithubHelp home page GithubHelp logo

Comments (4)

xMAC94x avatar xMAC94x commented on May 29, 2024 1

@besok 3 potential API changes would also be:

  • get rid of JsonPathInst, just export the JsonPath (in case it changes in the future, we use semver anyways)
  • change jsonpath_rust::JsonPathQuery interface to use a JsonPath rather than a &str, but at the same time implement the From<&str> trait for JsonPath, so that json.path("$..book[?(@.author size 10)].title".into()) works
  • we have JsonPathValue and JsonPtr, maybe we only need one and have Option<JsonPtr> for the None case

from jsonpath-rust.

xMAC94x avatar xMAC94x commented on May 29, 2024

I can have a look into these points after #58 got merged. Not a huge fan of gigantic refactoring PRs, rather do it in smaller steps. What do you think ?

from jsonpath-rust.

xMAC94x avatar xMAC94x commented on May 29, 2024

@besok any comment at this ? maybe any way to make communication easier than via github ? Like discord ?

from jsonpath-rust.

besok avatar besok commented on May 29, 2024

Hey! Sorry, I am on vacation and very slowly respond. Yeah, sure. You can take it and split it into a smaller prs. I will finish the review of the current pr this week.

from jsonpath-rust.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.