Comments (11)
Optimize my code? and there isn't one for this repo
from betterdiscord.
But you're using eslint Oo
/* eslint-disable no-console */
is in ./js/main.js
Yes optimize:
you're mixing i.Ex. single and double quotes, a windows linebreak-style, weired semicolon placements. So there is a lot to optimize ;)
from betterdiscord.
That's just due to the global eslint config of my editor, not an eslint for the repo. Yes I'm aware there are several mixing's of things. There is a lot of old code that existed before I forked it that I have not touched. It doesn't optimize or help the system to go and change those things. Also a person's preferred linebreak or semicolon placement doesn't make it not optimized or even necessarily wrong.
from betterdiscord.
That's true, but however it's easier to read ;)
from betterdiscord.
Again that comes down to personal preference
from betterdiscord.
Uhm... ok. It's your project and your decision. But I recommend you start writing clean code. Not for nothing there are a lot of books for this purpose.
from betterdiscord.
That's rather rude, I have a master's degree in a relevant field I am aware of what I am doing. Perhaps you should check out BDv2 or my plugin library for "clean code".
from betterdiscord.
Also as a side note this isn't really my project, it is a fork of a project that fixes several issues, it is not meant to be an entire rewrite and cleanup.
from betterdiscord.
I know, I saw the "forked from Jiiks/BetterDiscordApp" note ;)
OT:
I do not want to offend you now and please do not take this as a criticism of you. Just because you have a "master" in one area does not mean you're good at it. You can see such examples every day, whether it's economy, politics or other areas.
I looked at your "BetterDiscordAddons" -> "ReplySystem.plugin.js" but there are i.E. missing Tabs, wrong placed curly brackets, ... too
In summary: I just want to help, give tips and not criticize you
from betterdiscord.
You do not receive a masters of science degree for being bad in a field. That's just not how the world works. You wouldn't pass the thesis defense.
That plugin you mentioned is transpiled from a properly formatted source. I don't want to take the time to format it myself on every build.
Helping is one thing, but you were just being rude.
from betterdiscord.
Let me know if that is sufficient for you
from betterdiscord.
Related Issues (20)
- BetterDiscord appears to have @everyone tag broken [BUG] HOT 2
- [Feature] Native Apple silicon build support HOT 8
- BetterDiscord just not installing on the latest Discord Version HOT 2
- [Feature] ✨ BetterDiscord & Vencord United HOT 3
- [Bug] When i install TypingIndicator plugin there is nothing loading i tried it but it doesnt work HOT 1
- [Bug] Context menu caret icons peak through submenu HOT 2
- [Bug] "Check updates" doesn't work for plugins HOT 3
- Unable to see Emoji of any kind in client [Bug] HOT 3
- [Bug] BD crashes when opening a DM HOT 3
- [Bug] Lost activity icon HOT 2
- [Bug] Installing on linux does nothing HOT 4
- [Feature] [bug] Use correct file explorer app
- [Bug] Linux installer doesn't run out of the box on Ubuntu 24.04 HOT 4
- [Feature] Installer CLI Flags HOT 1
- Have a web extension and userscript for BetterDiscord HOT 2
- [Bug] Right-Click not working in Windowed DevTools HOT 12
- [Bug] BetterDiscord broken after latest Discord update HOT 5
- [Bug] Betterdiscord settings are showing, but no plugins work HOT 1
- in app notification not working HOT 3
- [Feature] Automatic theme switching for Nitro themes HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from betterdiscord.