GithubHelp home page GithubHelp logo

Comments (5)

simbleau avatar simbleau commented on May 24, 2024 1

This makes sense since NonSend resources must be dropped on the thread in which they're initialized. With pipelined rendering enabled, the render app/world are sent to a dedicated thread, and ping-pongs between the main thread and the render thread. If you initialized the NonSend resource on the main thread, it shouldn't be accessible on any other thread.

If you can avoid using a !Send type as a resource, I strongly suggest avoiding it if possible. If that isn't possible, you may want add it to the main app and use a Send proxy that is used in the render app. This is what bevy_winit does.

Long term, we are planning on moving !Send resources from the World entirely, moving them into App instead. See #9122.

To add to that, subapps are likely to be replaced with a world-based abstraction, rather than a full app, eliminating this footgun completely.

Depending on how long the above solutions will take, this should be documented in NonSend/NonSendMut. There's no mention of this footgun. ;)

from bevy.

seabassjh avatar seabassjh commented on May 24, 2024

I can reproduce this

from bevy.

james7132 avatar james7132 commented on May 24, 2024

This makes sense since NonSend resources must be dropped on the thread in which they're initialized. With pipelined rendering enabled, the render app/world are sent to a dedicated thread, and ping-pongs between the main thread and the render thread. If you initialized the NonSend resource on the main thread, it shouldn't be accessible on any other thread.

If you can avoid using a !Send type as a resource, I strongly suggest avoiding it if possible. If that isn't possible, you may want add it to the main app and use a Send proxy that is used in the render app. This is what bevy_winit does.

Long term, we are planning on moving !Send resources from the World entirely, moving them into App instead. See #9122.

from bevy.

alice-i-cecile avatar alice-i-cecile commented on May 24, 2024

To add to that, subapps are likely to be replaced with a world-based abstraction, rather than a full app, eliminating this footgun completely.

from bevy.

alice-i-cecile avatar alice-i-cecile commented on May 24, 2024

Yep, totally happy to see a note added to the documentation.

from bevy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.