GithubHelp home page GithubHelp logo

Mutable Animation Clips about bevy HOT 6 CLOSED

nzhao95 avatar nzhao95 commented on September 27, 2024
Mutable Animation Clips

from bevy.

Comments (6)

NthTensor avatar NthTensor commented on September 27, 2024 1

It would be lovely if you would write a PR for this. Otherwise it may be some time before someone starts working on it.

from bevy.

nzhao95 avatar nzhao95 commented on September 27, 2024 1

Nice ! I'll get on it thanks a ton

from bevy.

NthTensor avatar NthTensor commented on September 27, 2024

Each AnimationGraphNode contains an Handle<AnimationClip>. You can get a mutable interference to the underlying clip from Assets<AnimationClip>. So it looks like we are just missing methods

fn curves_mut(&mut self) -> &mut HashMap<AnimationTargetId, Vec<VariableCurve>>
fn curves_for_target_mut(&mut self, target_id: AnimationTargetId) -> Option<&mut Vec<VariableCurve>>

on AnimationClip. Seem correct?

from bevy.

nzhao95 avatar nzhao95 commented on September 27, 2024

Hello, thanks for getting back so quickly. Exactly those mutable getters would be really nice to have. For my use case it's really crucial. I don't know if there are good reasons not to have them but if they aren't it would be super cool to have them !

from bevy.

NthTensor avatar NthTensor commented on September 27, 2024

I think we just never bothered to add them. Looks like a good addition to me. I've tagged this as a good first issue.

from bevy.

nzhao95 avatar nzhao95 commented on September 27, 2024

Cool ! Should I write the code and ask for a PR or is it going to be taken care of ?

from bevy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.