GithubHelp home page GithubHelp logo

OwningPtr should impl From<Box<T>> about bevy HOT 2 OPEN

dmyyy avatar dmyyy commented on September 26, 2024
OwningPtr should impl From>

from bevy.

Comments (2)

SkiFire13 avatar SkiFire13 commented on September 26, 2024 2

Another reason why this should be avoided is that OwningPtr only owns the data, not the allocation, so the proposed conversion would have to leak the allocation.

I would instead suggest using ReflectComponent to insert a reflected value as component.

from bevy.

MrGVSV avatar MrGVSV commented on September 26, 2024 1

Note that for dyn Reflect we probably want to only do this via the ReflectFromPtr type data.

The reason for this is because a Box<dyn Reflect> might not actually be a Box<T>.

Specifically, when cloning via Reflect::clone_value, you almost always get back a dynamic type (e.g. Box<DynamicStruct>). It would be unsafe to treat the OwningPtr as one that points to T when it really points to DynamicStruct.

So ideally we expose this API through the ReflectFromPtr type data to help ensure these kinds of operations are done safely.

from bevy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.