Comments (6)
I went through all subcrates and fixed everything I could find. I consider this done.
from bevy.
FYI, there was talk of deprecating
reflect(Debug)
, so by adding this, you may be increasing future workload. Can we skip that one? Ping @MrGVSV
I'm on the fence about deprecating it. I agree that generally speaking, the reflection-based Debug
impl should work for most cases. However, there are many cases where a custom Debug
impl might be desired. And the PR to deprecate it (#11625) uses autoref specialization magic to automatically implement it.
I'd like to see benchmarks and/or a breakdown of performance, maintainability, and support implications before committing to that idea. Or at the very least, I'd like to know that Bevy is comfortable with utilizing these quasi-specialization hacks.
Until then, I think it's perfectly fine—and probably desirable—to add reflect(Debug)
to types.
from bevy.
FYI, there was talk of deprecating reflect(Debug)
, so by adding this, you may be increasing future workload. Can we skip that one? Ping @MrGVSV
Edit: leave it in, per reasoning below
from bevy.
This should be done, but is easy to forget. When tackling this, please handle it one crate or so at a time: it's helpful to avoid merge conflicts and review burden.
from bevy.
I'm working on this but can only get started on Sunday, so no pull request just yet.
I'm also wondering if a lint could be written to remind people to do this on future components and resources.
I'll investigate that one when I'm done with this issue.
from bevy.
@blazepaws much appreciated, thanks!
from bevy.
Related Issues (20)
- missing_const_for_thread_local HOT 1
- bevy_reflect fails to build HOT 5
- Register asset saver? HOT 1
- Dynamic queries with optional components
- Add example demonstrating how to achieve cross-platform deterministic math
- GLTF error message could be more informative
- Extrudable not implemented for Polygons HOT 2
- `init_state` calls done before StatePlugin is added lead to an unwrap error. HOT 3
- Picking sprite backend will panic with Ord violation HOT 2
- Potentially confusing mistake in comment at 3d/generate_custom_mesh example
- Introduce `QuerySingle<Q, F>` family of system parameters HOT 8
- Systems should be skipped if their resources cannot be fetched HOT 26
- WindowResized events don't trigger HOT 1
- Move methods on `Children` that mutate to `EntityCommands` HOT 1
- I am getting a stack overflow error from loading too many animations at once HOT 1
- Text rendered in 2d inside of a child bundle is extremely large HOT 3
- Audio not always played ? HOT 6
- Panic loading GLB file
- Asset processing cannot be configured from code
- Way to disable renderer for specific window.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bevy.