GithubHelp home page GithubHelp logo

Comments (6)

blazepaws avatar blazepaws commented on September 27, 2024 4

I went through all subcrates and fixed everything I could find. I consider this done.

from bevy.

MrGVSV avatar MrGVSV commented on September 27, 2024 2

FYI, there was talk of deprecating reflect(Debug), so by adding this, you may be increasing future workload. Can we skip that one? Ping @MrGVSV

I'm on the fence about deprecating it. I agree that generally speaking, the reflection-based Debug impl should work for most cases. However, there are many cases where a custom Debug impl might be desired. And the PR to deprecate it (#11625) uses autoref specialization magic to automatically implement it.

I'd like to see benchmarks and/or a breakdown of performance, maintainability, and support implications before committing to that idea. Or at the very least, I'd like to know that Bevy is comfortable with utilizing these quasi-specialization hacks.

Until then, I think it's perfectly fine—and probably desirable—to add reflect(Debug) to types.

from bevy.

janhohenheim avatar janhohenheim commented on September 27, 2024 1

FYI, there was talk of deprecating reflect(Debug), so by adding this, you may be increasing future workload. Can we skip that one? Ping @MrGVSV

Edit: leave it in, per reasoning below

from bevy.

alice-i-cecile avatar alice-i-cecile commented on September 27, 2024

This should be done, but is easy to forget. When tackling this, please handle it one crate or so at a time: it's helpful to avoid merge conflicts and review burden.

from bevy.

blazepaws avatar blazepaws commented on September 27, 2024

I'm working on this but can only get started on Sunday, so no pull request just yet.

I'm also wondering if a lint could be written to remind people to do this on future components and resources.
I'll investigate that one when I'm done with this issue.

from bevy.

janhohenheim avatar janhohenheim commented on September 27, 2024

@blazepaws much appreciated, thanks!

from bevy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.