GithubHelp home page GithubHelp logo

Comments (4)

robisim74 avatar robisim74 commented on June 2, 2024 1

Thanks! Tested, it works well.

Greetings

from inline-critical.

bezoerb avatar bezoerb commented on June 2, 2024

Hey @robisim74, thanks for this detailed bug report :)
I'm currently very busy but hopefully i will find some spare time to look into this after Christmas. Would it be possible for you to create a gist or a simple demo setup to reproduce the issue? This would make debugging a lot easier :)

from inline-critical.

robisim74 avatar robisim74 commented on June 2, 2024

Yes, you can find a starter repo here: https://github.com/robisim74/nodejs-mvc

Just add extract: true to the options of inline-critical in build.js file: https://github.com/robisim74/nodejs-mvc/blob/main/build.js#L48-L50

Then run npm run build : you'll find the result in dist\views\index.html

To see what happens in the browser, run npm start

Hope this helps!

If you agree, I can also try to do a pr.

from inline-critical.

bezoerb avatar bezoerb commented on June 2, 2024

Hey @robisim74,
this should be fixed in v9.0.1

Thanks for the starter repo :)

Would you mind trying if everything works as expected?

from inline-critical.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.