bgamari / auto-push Goto Github PK

The problem: SQLite does not actually support fully concurrent transactions; instead, any transaction that wants to start when another transaction is already active waits until the other transaction releases its lock, or until the attempt times out. We now have a few transactions that are long enough to trigger such timeouts.

Possible solution approaches:

1. See if we can increase the SQLite busy timeout.
2. Use the withTransaction machinery to force transactions to run serially. This will avoid the "database is locked" error, but if any transaction fails to terminate, it will block everything else. This, in turn, means we'd have to add our own timeout, but then we'd just be reinventing the same wheel (albeit with a timeout that we control).
3. Figure out a way to make those transactions shorter, i.e., do the thing that now happens inside the transaction outside of a transaction. This would require extending the MergeRequest data model to support more fine-grained states, and dealing with the resulting in-between transitions.
4. Use PostgreSQL.