GithubHelp home page GithubHelp logo

Navigation CSS about ea-genesis-child HOT 9 CLOSED

billerickson avatar billerickson commented on July 30, 2024
Navigation CSS

from ea-genesis-child.

Comments (9)

tnorthcutt avatar tnorthcutt commented on July 30, 2024

The sample child theme has submenu items that don't look off - how do they do it in that theme? It uses display: inline-block;

from ea-genesis-child.

jaredatch avatar jaredatch commented on July 30, 2024

If you highlight the menu text on genesisframework.com, you'll see the gaps.

http://cl.ly/image/3V092u0U062j

from ea-genesis-child.

billerickson avatar billerickson commented on July 30, 2024

Related: http://css-tricks.com/fighting-the-space-between-inline-block-elements/

I only use inline-block if I have to center the menu.

I agree, display:block; float:left should be used as the default.

from ea-genesis-child.

tnorthcutt avatar tnorthcutt commented on July 30, 2024

Gotcha, didn't realize that. display:block; makes sense to me, then.

from ea-genesis-child.

GaryJones avatar GaryJones commented on July 30, 2024

If this is changed back, can the styles needed to make a centred menu get added to the CSS Snippets wiki page?

Doesn't IE (oldIE?) still require a width property when float is used?

from ea-genesis-child.

jaredatch avatar jaredatch commented on July 30, 2024

It's like 3 lines of code so should be easy to change back if needed. Only reason to ever have display:inline-block would be to center the nav.

G 2.0 shouldn't have it set like this for default, but to each his own.

from ea-genesis-child.

GaryJones avatar GaryJones commented on July 30, 2024

Worth raising as an issue in G core?

from ea-genesis-child.

GaryJones avatar GaryJones commented on July 30, 2024

If someone can do a PR for core, then if it gets accepted, it's one less thing that we deviate on (and that's a good thing).

from ea-genesis-child.

jaredatch avatar jaredatch commented on July 30, 2024

Done, let me know if it needs tweaking. I mentioned to Lauren about this, don't know if she relayed that to Brian or not through. The inline-block method is nothing but trouble and is only useful for centering your nav, but that's an edge case.

from ea-genesis-child.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.