Comments (9)
The sample child theme has submenu items that don't look off - how do they do it in that theme? It uses display: inline-block;
from ea-genesis-child.
If you highlight the menu text on genesisframework.com, you'll see the gaps.
http://cl.ly/image/3V092u0U062j
from ea-genesis-child.
Related: http://css-tricks.com/fighting-the-space-between-inline-block-elements/
I only use inline-block if I have to center the menu.
I agree, display:block; float:left should be used as the default.
from ea-genesis-child.
Gotcha, didn't realize that. display:block; makes sense to me, then.
from ea-genesis-child.
If this is changed back, can the styles needed to make a centred menu get added to the CSS Snippets wiki page?
Doesn't IE (oldIE?) still require a width property when float is used?
from ea-genesis-child.
It's like 3 lines of code so should be easy to change back if needed. Only reason to ever have display:inline-block would be to center the nav.
G 2.0 shouldn't have it set like this for default, but to each his own.
from ea-genesis-child.
Worth raising as an issue in G core?
from ea-genesis-child.
If someone can do a PR for core, then if it gets accepted, it's one less thing that we deviate on (and that's a good thing).
from ea-genesis-child.
Done, let me know if it needs tweaking. I mentioned to Lauren about this, don't know if she relayed that to Brian or not through. The inline-block method is nothing but trouble and is only useful for centering your nav, but that's an edge case.
from ea-genesis-child.
Related Issues (20)
- Accessibility Error: Empty Button on Submenu dropdown HOT 3
- Create some basic comment styling
- 3rd party font rendering work around HOT 6
- Create GF basic error styling HOT 5
- Remove customizer stuff HOT 4
- Remove hover on hyperlinked icons HOT 1
- Genesis menu disappears sometimes HOT 1
- Smooth Scroll problem
- Add accessibility
- Flexbox Menus and more
- global.js updates for better validation HOT 6
- Genesis 2.3.0 adds image wrapper markup
- Remove the site title if a custom header is used? HOT 3
- CSS HOT 1
- Is this comment markup really correct? HOT 1
- ACF Custom Fields disappear from Admin menu HOT 2
- Undefined mixin media HOT 1
- Editor Style Not working HOT 1
- About menu
- Svg Icon HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ea-genesis-child.